Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace macro_rules! visitors with dedicated methods #4402

Merged
merged 1 commit into from
May 12, 2023

Conversation

charliermarsh
Copy link
Member

@charliermarsh charliermarsh commented May 12, 2023

These aren't necessary. It's simpler to use methods.

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@charliermarsh charliermarsh merged commit 490301f into main May 12, 2023
@charliermarsh charliermarsh deleted the charlie/macro branch May 12, 2023 21:06
@github-actions
Copy link
Contributor

github-actions bot commented May 12, 2023

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     16.7±0.07ms     2.4 MB/sec    1.00     16.7±0.08ms     2.4 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.0±0.01ms     4.1 MB/sec    1.00      4.0±0.02ms     4.1 MB/sec
linter/all-rules/numpy/globals.py          1.00    494.1±1.07µs     6.0 MB/sec    1.00    492.0±2.08µs     6.0 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.9±0.04ms     3.7 MB/sec    1.00      6.9±0.03ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.00      8.1±0.03ms     5.0 MB/sec    1.00      8.1±0.02ms     5.0 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.01  1754.3±41.15µs     9.5 MB/sec    1.00   1738.7±3.04µs     9.6 MB/sec
linter/default-rules/numpy/globals.py      1.00    191.5±0.46µs    15.4 MB/sec    1.00    192.3±1.03µs    15.3 MB/sec
linter/default-rules/pydantic/types.py     1.01      3.7±0.01ms     7.0 MB/sec    1.00      3.6±0.02ms     7.0 MB/sec
parser/large/dataset.py                    1.09      7.0±0.01ms     5.8 MB/sec    1.00      6.5±0.01ms     6.3 MB/sec
parser/numpy/ctypeslib.py                  1.07   1340.9±0.91µs    12.4 MB/sec    1.00   1257.3±1.03µs    13.2 MB/sec
parser/numpy/globals.py                    1.06    134.5±0.22µs    21.9 MB/sec    1.00    127.3±0.22µs    23.2 MB/sec
parser/pydantic/types.py                   1.07      3.0±0.00ms     8.6 MB/sec    1.00      2.8±0.00ms     9.2 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     19.9±0.61ms     2.0 MB/sec    1.03     20.6±0.66ms  2025.8 KB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      5.1±0.21ms     3.3 MB/sec    1.02      5.2±0.16ms     3.2 MB/sec
linter/all-rules/numpy/globals.py          1.00   582.0±23.27µs     5.1 MB/sec    1.05   611.7±28.90µs     4.8 MB/sec
linter/all-rules/pydantic/types.py         1.00      8.2±0.27ms     3.1 MB/sec    1.04      8.5±0.27ms     3.0 MB/sec
linter/default-rules/large/dataset.py      1.00     10.0±0.26ms     4.1 MB/sec    1.01     10.0±0.21ms     4.1 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00      2.1±0.07ms     8.1 MB/sec    1.04      2.1±0.09ms     7.8 MB/sec
linter/default-rules/numpy/globals.py      1.00   238.0±10.26µs    12.4 MB/sec    1.01   241.1±19.54µs    12.2 MB/sec
linter/default-rules/pydantic/types.py     1.03      4.6±0.19ms     5.6 MB/sec    1.00      4.4±0.12ms     5.8 MB/sec
parser/large/dataset.py                    1.00      8.1±0.22ms     5.0 MB/sec    1.02      8.2±0.18ms     5.0 MB/sec
parser/numpy/ctypeslib.py                  1.00  1508.0±45.80µs    11.0 MB/sec    1.05  1588.6±60.95µs    10.5 MB/sec
parser/numpy/globals.py                    1.00    156.5±6.61µs    18.9 MB/sec    1.02   159.8±12.25µs    18.5 MB/sec
parser/pydantic/types.py                   1.00      3.4±0.09ms     7.5 MB/sec    1.03      3.5±0.08ms     7.3 MB/sec

MichaReiser pushed a commit that referenced this pull request Jul 27, 2023
Remove unreachable code in `compiler/parser/src/string_parser.rs`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants