Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename a variety of rules to match updated conventions #3283

Merged
merged 3 commits into from
Mar 18, 2023
Merged

Rename a variety of rules to match updated conventions #3283

merged 3 commits into from
Mar 18, 2023

Conversation

charliermarsh
Copy link
Member

See: #2902.

@charliermarsh
Copy link
Member Author

This will fail, as I've only renamed them in registry.rs, for the purpose of review / discussion.

@charliermarsh
Copy link
Member Author

\cc @not-my-profile -- not urgent, but any feedback on these?

@charliermarsh charliermarsh force-pushed the charlie/rename-rules branch 2 times, most recently from 2fcebaf to d3928d2 Compare February 28, 2023 21:35
@charliermarsh charliermarsh force-pushed the charlie/rename-rules branch 2 times, most recently from 7f10817 to b95813b Compare March 18, 2023 21:07
@github-actions
Copy link
Contributor

github-actions bot commented Mar 18, 2023 •
edited
Loading

PR Check Results

Ecosystem

✅ ecosystem check detected no changes.

Benchmark

Linux

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.0±0.24ms     2.7 MB/sec    1.02     15.3±0.27ms     2.7 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.02      4.0±0.05ms     4.2 MB/sec    1.00      3.9±0.09ms     4.3 MB/sec
linter/all-rules/numpy/globals.py          1.01    452.9±3.10µs     6.5 MB/sec    1.00    448.3±1.49µs     6.6 MB/sec
linter/all-rules/pydantic/types.py         1.08      7.0±0.10ms     3.7 MB/sec    1.00      6.5±0.01ms     4.0 MB/sec
linter/default-rules/large/dataset.py      1.03      8.5±0.01ms     4.8 MB/sec    1.00      8.2±0.02ms     4.9 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.03  1835.1±10.94µs     9.1 MB/sec    1.00   1776.9±6.39µs     9.4 MB/sec
linter/default-rules/numpy/globals.py      1.01    188.5±0.80µs    15.7 MB/sec    1.00    186.9±0.32µs    15.8 MB/sec
linter/default-rules/pydantic/types.py     1.07      4.1±0.07ms     6.3 MB/sec    1.00      3.8±0.05ms     6.7 MB/sec

Windows

group                                      main                                   pr
-----                                      ----                                   --
linter/all-rules/large/dataset.py          1.00     15.5±0.13ms     2.6 MB/sec    1.01     15.6±0.20ms     2.6 MB/sec
linter/all-rules/numpy/ctypeslib.py        1.00      4.2±0.06ms     4.0 MB/sec    1.00      4.2±0.04ms     4.0 MB/sec
linter/all-rules/numpy/globals.py          1.00    536.1±6.59µs     5.5 MB/sec    1.01    540.4±8.11µs     5.5 MB/sec
linter/all-rules/pydantic/types.py         1.00      6.8±0.05ms     3.7 MB/sec    1.00      6.8±0.09ms     3.7 MB/sec
linter/default-rules/large/dataset.py      1.01      8.7±0.08ms     4.7 MB/sec    1.00      8.6±0.07ms     4.7 MB/sec
linter/default-rules/numpy/ctypeslib.py    1.00  1898.8±27.01µs     8.8 MB/sec    1.00  1890.6±29.41µs     8.8 MB/sec
linter/default-rules/numpy/globals.py      1.00    209.5±3.65µs    14.1 MB/sec    1.01    211.3±5.43µs    14.0 MB/sec
linter/default-rules/pydantic/types.py     1.01      4.0±0.07ms     6.3 MB/sec    1.00      4.0±0.05ms     6.4 MB/sec

@charliermarsh charliermarsh merged commit 4ffcd83 into main Mar 18, 2023
@charliermarsh charliermarsh deleted the charlie/rename-rules branch March 18, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-my-profile not-my-profile not-my-profile left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charliermarsh @not-my-profile