-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include document specific debug info #16215
Conversation
c700a50
to
8abfba3
Compare
cd69876
to
3346e4f
Compare
|
3346e4f
to
62ff785
Compare
let argument: DebugCommandArgument = params.arguments.into_iter().next().map_or_else( | ||
|| Ok(DebugCommandArgument::default()), | ||
|value| serde_json::from_value(value).with_failure_code(ErrorCode::InvalidParams), | ||
)?; | ||
let output = debug_information(session, argument.uri) | ||
.with_failure_code(ErrorCode::InternalError)?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we only look at the first argument but a potential new VS Code command could be to look at all opened documents which would require passing multiple arguments. But, I'm going to leave this for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great and i also forgot about it. At least, it never came to my mind when asking users for debugging information which is a shame.
75792db
to
8408d65
Compare
8408d65
to
01dff16
Compare
## Summary Related to astral-sh/ruff#16215 ## Test Plan The output in astral-sh/ruff#16215 is by using this PR.
* main: (60 commits) [`refurb`] Manual timezone monkeypatching (`FURB162`) (#16113) [`pyupgrade`] Do not upgrade functional TypedDicts with private field names to the class-based syntax (`UP013`) (#16219) Improve docs for PYI019 (#16229) Refactor `CallOutcome` to `Result` (#16161) Fix minor punctuation errors (#16228) Include document specific debug info (#16215) Update server to return the debug info as string (#16214) [`airflow`] Group `ImportPathMoved` and `ProviderName` to avoid misusing (`AIR303`) (#16157) Fix unstable formatting of trailing end-of-line comments of parenthesized attribute values (#16187) Ignore source code actions for a notebook cell (#16154) Add FAQ entry for `source.*` code actions in Notebook (#16212) red-knot: move symbol lookups in `symbol.rs` (#16152) better error messages while loading configuration `extend`s (#15658) Format `index.css` (#16207) Improve API exposed on `ExprStringLiteral` nodes (#16192) Update Rust crate tempfile to v3.17.0 (#16202) Update cloudflare/wrangler-action action to v3.14.0 (#16203) Update NPM Development dependencies (#16199) Update Rust crate smallvec to v1.14.0 (#16201) Update Rust crate codspeed-criterion-compat to v2.8.0 (#16200) ...
Summary
Related astral-sh/ruff-vscode#692.
Test Plan
When there's no active text document:
When there's an active text document that's been passed as param:
Replace
...
at the end with the output ofruff check --show-settings path.py