Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flake8-bandit] Add missing single-line/dotall regex flag (S608) #15654

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #15653.

Test Plan

cargo nextest run and cargo insta test.

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

ℹ️ ecosystem check detected linter changes. (+5 -0 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/airflow (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ providers/tests/integration/google/cloud/transfers/test_mssql_to_gcs.py:58:13: S608 Possible SQL injection vector through string-based query construction
+ providers/tests/system/google/cloud/dataflow/example_dataflow_sql.py:97:15: S608 Possible SQL injection vector through string-based query construction

apache/superset (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --no-preview --select ALL

+ superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py:871:9: S608 Possible SQL injection vector through string-based query construction

ibis-project/ibis (+1 -0 violations, +0 -0 fixes)

+ ibis/backends/mssql/__init__.py:322:17: S608 Possible SQL injection vector through string-based query construction

indico/indico (+1 -0 violations, +0 -0 fixes)

+ indico/migrations/versions/20210224_1808_26806768cd3f_remove_flower_oauth_app.py:31:16: S608 Possible SQL injection vector through string-based query construction

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
S608 5 5 0 0 0

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+5 -0 violations, +0 -0 fixes in 4 projects; 51 projects unchanged)

apache/airflow (+2 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ providers/tests/integration/google/cloud/transfers/test_mssql_to_gcs.py:58:13: S608 Possible SQL injection vector through string-based query construction
+ providers/tests/system/google/cloud/dataflow/example_dataflow_sql.py:97:15: S608 Possible SQL injection vector through string-based query construction

apache/superset (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview --select ALL

+ superset/migrations/versions/2022-04-01_14-38_a9422eeaae74_new_dataset_models_take_2.py:871:9: S608 Possible SQL injection vector through string-based query construction

ibis-project/ibis (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ ibis/backends/mssql/__init__.py:322:17: S608 Possible SQL injection vector through string-based query construction

indico/indico (+1 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --no-fix --output-format concise --preview

+ indico/migrations/versions/20210224_1808_26806768cd3f_remove_flower_oauth_app.py:31:16: S608 Possible SQL injection vector through string-based query construction

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
S608 5 5 0 0 0

@dhruvmanila dhruvmanila added the bug Something isn't working label Jan 22, 2025
@dhruvmanila dhruvmanila merged commit f54b821 into astral-sh:main Jan 22, 2025
21 checks passed
@InSyncWithFoo InSyncWithFoo deleted the S608 branch January 22, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False negative in SQL injection detection (S608) when selecting multiple columns across multiple lines
2 participants