Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[red-knot] Remove unneeded branch in Type::is_equivalent_to() #15242

Merged
merged 1 commit into from
Jan 3, 2025

Conversation

AlexWaygood
Copy link
Member

Summary

We understand sys.version_info branches now! As such, I believe this branch is no longer required; all tests pass without it. I also ran QUICKCHECK_TESTS=100000 cargo test -p red_knot_python_semantic -- --ignored types::property_tests::stable, and no tests failed except for the known issue with Type::is_assignable_to() (#14899)

Test Plan

See above

@AlexWaygood AlexWaygood added the red-knot Multi-file analysis & type inference label Jan 3, 2025
Copy link
Contributor

github-actions bot commented Jan 3, 2025

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Copy link
Contributor

@sharkdp sharkdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed an earlier version of this check in my statically-known-branches PR, but probably missed this during a rebase. The early-return-version of is_equivalent_to arrived at some point when that PR was open, IIRC. Anyway, thank you!

@AlexWaygood AlexWaygood merged commit bde8ecd into main Jan 3, 2025
21 checks passed
@AlexWaygood AlexWaygood deleted the alex/final-improvements branch January 3, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
red-knot Multi-file analysis & type inference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants