[ruff] Fix false positive on global keyword (RUF052)
#15235
Merged
+645
−627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Garrett-R
commented
Jan 3, 2025
Garrett-R
force-pushed
the
garrett/14996/ruff052-fix-global-keyword
branch
from
ce679c7 to
70f2f89
Compare
Garrett-R
commented
Jan 3, 2025
Garrett-R
commented
Jan 3, 2025
|
MichaReiser
reviewed
Jan 3, 2025
|
@charliermarsh would you mind taking a look at my comment so that we can move forward with this PR? |
Garrett-R
force-pushed
the
garrett/14996/ruff052-fix-global-keyword
branch
from
70f2f89 to
5155f96
Compare
Garrett-R
commented
Jan 14, 2025
There was a problem hiding this comment.
Note: I've reviewed the 3 snapshot files. As expected they have no "real" changes, just line numbers changing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14996.
BTW, the issue correctly reports a false positive given that the docs say "Only local variables in function scopes are flagged by the rule".
Test Plan
I added the false positive to the fixture and verified it indeed caused a false positive before my fix was done.