Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airflow]: extend moved names (AIR303) #15145

Merged
merged 2 commits into from
Dec 26, 2024

Conversation

Lee-W
Copy link
Contributor

@Lee-W Lee-W commented Dec 26, 2024

Summary

Many core Airflow features have been deprecated and moved to Airflow Providers since users might need to install an additional package (e.g., apache-airflow-provider-fab==1.0.0); a separate rule (AIR303) is created for this.

The following is the ones that has been moved to apache-airflow-provider-celery==3.0.0

  • airflow.config_templates.default_celery.DEFAULT_CELERY_CONFIGairflow.providers.celery.executors.default_celery.DEFAULT_CELERY_CONFIG

Test Plan

A test fixture has been included for the rule.

…CONFIG → airflow.providers.celery.executors.default_celery.DEFAULT_CELERY_CONFIG
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+4 -0 violations, +0 -0 fixes in 1 projects; 54 projects unchanged)

pandas-dev/pandas (+4 -0 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ pandas/io/excel/_odfreader.py:11:5: TC001 Move application import `pandas._typing.FilePath` into a type-checking block
+ pandas/io/excel/_odfreader.py:12:5: TC001 Move application import `pandas._typing.ReadBuffer` into a type-checking block
+ pandas/io/excel/_odfreader.py:13:5: TC001 Move application import `pandas._typing.Scalar` into a type-checking block
+ pandas/io/excel/_odfreader.py:14:5: TC001 Move application import `pandas._typing.StorageOptions` into a type-checking block

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
TC001 4 4 0 0 0

@MichaReiser MichaReiser added rule Implementing or modifying a lint rule preview Related to preview mode features labels Dec 26, 2024
@MichaReiser MichaReiser merged commit 5d6aae8 into astral-sh:main Dec 26, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Related to preview mode features rule Implementing or modifying a lint rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants