Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use TypeChecker for detecting fastapi routes #15093

Merged
merged 2 commits into from
Dec 21, 2024
Merged

Use TypeChecker for detecting fastapi routes #15093

merged 2 commits into from
Dec 21, 2024
+88 −11

Conversation

TomerBin
Copy link
Contributor

Resolves #14903

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 21, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@TomerBin TomerBin force-pushed the tomer/detect-fast-api-routes-by-annotation branch from 8394b98 to f4431a7 Compare December 21, 2024 12:47
MichaReiser
MichaReiser approved these changes Dec 21, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@MichaReiser MichaReiser merged commit 2fb6b32 into astral-sh:main Dec 21, 2024
21 checks passed
@MichaReiser MichaReiser added the bug Something isn't working label Dec 21, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jan 2, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RUF029 triggers on FastAPI routes when they're inner functions
2 participants
@TomerBin @MichaReiser