Initialize Rust cache before installing binaries and additional components #14459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zanieb
added
internal
|
|
@zanieb are you planning to work on this? I'd otherwise suggest that we close it or convert it into an issue. |
|
Funny, I did this again in #15660 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was hoping to reduce the time spent on binary installs, but unfortunately additional binaries are always reinstalled taiki-e/install-action#577 — unfortunately that increases the cache size.
However, this does cache setup of the Rust toolchain which may save time. Since most of the Rust toolchain installation is just downloading components, and we still need to download the cache, there might not be much time saved here. The benefit is that the cache is generally closer to the runner on the network. Toolchain installation takes ~10s on Linux and >1m on Windows. It looks like there are some nice savings on Windows but it's less clear on Linux. The pre-commit job is 10s faster, but (perhaps due to the bug above) the test job is 8s slower.