Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update insta snapshots #14366

Merged
merged 1 commit into from
Nov 15, 2024
Merged

Update insta snapshots #14366

merged 1 commit into from
Nov 15, 2024

Conversation

MichaReiser
Copy link
Member

Summary

Cargo insta made updates to its snapshot formats. The new format isn't applied
unless there are other changes to the snapshot. I've found this annoying
when a snapshot test failed, I accepted the changes, and then fixed the regression
because I then ended up with an "empty" snapshot change that updated the snapshot to the new layout.

This PR updates all snapshots to use the new insta snapshot layout

Test Plan

cargo test

@MichaReiser MichaReiser added the testing Related to testing Ruff itself label Nov 15, 2024
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

@dylwil3
Copy link
Collaborator

dylwil3 commented Nov 15, 2024

Biggest diff of the year award! 🏆

@MichaReiser
Copy link
Member Author

haha :)

@MichaReiser MichaReiser merged commit c847cad into main Nov 15, 2024
20 checks passed
@MichaReiser MichaReiser deleted the micha/update-snapshots branch November 15, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Related to testing Ruff itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants