[flake8-simplify] Extend open-file-with-context-handler to work with other standard-library IO modules (SIM115)
#12959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith `tempfile` (`SIM115`)
|
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SIM115 | 78 | 39 | 39 | 0 | 0 |
Linter (preview)
ℹ️ ecosystem check detected linter changes. (+68 -39 violations, +0 -0 fixes in 7 projects; 47 projects unchanged)
apache/airflow (+36 -24 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ airflow/models/dag.py:793:24: SIM115 Use a context manager for opening files - airflow/models/dag.py:793:24: SIM115 Use context handler for opening files + airflow/providers/amazon/aws/hooks/s3.py:1451:20: SIM115 Use a context manager for opening files - airflow/providers/amazon/aws/hooks/s3.py:1451:20: SIM115 Use context handler for opening files + airflow/providers/amazon/aws/hooks/s3.py:1453:20: SIM115 Use a context manager for opening files + airflow/providers/amazon/aws/transfers/dynamodb_to_s3.py:247:29: SIM115 Use a context manager for opening files + airflow/providers/docker/operators/docker.py:487:19: SIM115 Use a context manager for opening files + airflow/providers/ftp/hooks/ftp.py:183:33: SIM115 Use a context manager for opening files - airflow/providers/ftp/hooks/ftp.py:183:33: SIM115 Use context handler for opening files + airflow/providers/ftp/hooks/ftp.py:216:28: SIM115 Use a context manager for opening files - airflow/providers/ftp/hooks/ftp.py:216:28: SIM115 Use context handler for opening files + airflow/providers/google/cloud/hooks/cloud_sql.py:934:22: SIM115 Use a context manager for opening files + airflow/providers/google/cloud/transfers/cassandra_to_gcs.py:195:27: SIM115 Use a context manager for opening files + airflow/providers/google/cloud/transfers/cassandra_to_gcs.py:212:35: SIM115 Use a context manager for opening files + airflow/providers/google/cloud/transfers/cassandra_to_gcs.py:228:34: SIM115 Use a context manager for opening files + airflow/providers/google/cloud/transfers/sql_to_gcs.py:354:27: SIM115 Use a context manager for opening files + airflow/providers/google/cloud/transfers/sql_to_gcs.py:465:34: SIM115 Use a context manager for opening files + airflow/utils/file.py:159:30: SIM115 Use a context manager for opening files + airflow/utils/file.py:161:16: SIM115 Use a context manager for opening files - airflow/utils/file.py:161:16: SIM115 Use context handler for opening files + dev/breeze/src/airflow_breeze/utils/console.py:86:16: SIM115 Use a context manager for opening files - dev/breeze/src/airflow_breeze/utils/console.py:86:16: SIM115 Use context handler for opening files + dev/breeze/src/airflow_breeze/utils/kubernetes_utils.py:185:24: SIM115 Use a context manager for opening files + dev/breeze/src/airflow_breeze/utils/parallel.py:62:12: SIM115 Use a context manager for opening files + dev/send_email.py:79:32: SIM115 Use a context manager for opening files - dev/send_email.py:79:32: SIM115 Use context handler for opening files + dev/stats/explore_pr_candidates.ipynb:cell 2:1:8: SIM115 Use a context manager for opening files - dev/stats/explore_pr_candidates.ipynb:cell 2:1:8: SIM115 Use context handler for opening files ... 32 additional changes omitted for project
apache/superset (+6 -1 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ RELEASING/generate_email.py:51:32: SIM115 Use a context manager for opening files - RELEASING/generate_email.py:51:32: SIM115 Use context handler for opening files + superset/commands/dataset/importers/v1/utils.py:198:16: SIM115 Use a context manager for opening files + tests/integration_tests/email_tests.py:160:22: SIM115 Use a context manager for opening files + tests/integration_tests/email_tests.py:44:22: SIM115 Use a context manager for opening files + tests/integration_tests/email_tests.py:64:22: SIM115 Use a context manager for opening files + tests/integration_tests/email_tests.py:95:22: SIM115 Use a context manager for opening files
bokeh/bokeh (+17 -14 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ docs/bokeh/source/conf.py:69:14: SIM115 Use a context manager for opening files - docs/bokeh/source/conf.py:69:14: SIM115 Use context handler for opening files + examples/server/app/spectrogram/main.py:32:17: SIM115 Use a context manager for opening files - examples/server/app/spectrogram/main.py:32:17: SIM115 Use context handler for opening files + release/build.py:157:29: SIM115 Use a context manager for opening files - release/build.py:157:29: SIM115 Use context handler for opening files + release/remote.py:31:16: SIM115 Use a context manager for opening files - release/remote.py:31:16: SIM115 Use context handler for opening files + release/remote.py:33:16: SIM115 Use a context manager for opening files - release/remote.py:33:16: SIM115 Use context handler for opening files + scripts/milestone.py:318:11: SIM115 Use a context manager for opening files - scripts/milestone.py:318:11: SIM115 Use context handler for opening files + scripts/sri.py:38:21: SIM115 Use a context manager for opening files - scripts/sri.py:38:21: SIM115 Use context handler for opening files ... 17 additional changes omitted for project
python-poetry/poetry (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ src/poetry/inspection/lazy_wheel.py:278:41: SIM115 Use a context manager for opening files
reflex-dev/reflex (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ reflex/utils/prerequisites.py:678:14: SIM115 Use a context manager for opening files
zulip/zulip (+1 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL
+ zerver/management/commands/backup.py:124:36: SIM115 Use a context manager for opening files
indico/indico (+6 -0 violations, +0 -0 fixes)
ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview
+ indico/modules/events/export.py:149:24: SIM115 Use a context manager for opening files + indico/modules/events/export.py:413:24: SIM115 Use a context manager for opening files + indico/modules/events/static/offline.py:91:21: SIM115 Use a context manager for opening files + indico/modules/events/util.py:369:17: SIM115 Use a context manager for opening files + indico/modules/events/util.py:710:21: SIM115 Use a context manager for opening files + indico/modules/users/export.py:79:17: SIM115 Use a context manager for opening files
Changes by rule (1 rules affected)
| code | total | + violation | - violation | + fix | - fix |
|---|---|---|---|---|---|
| SIM115 | 107 | 68 | 39 | 0 | 0 |
AlexWaygood
requested changes
Aug 18, 2024
There was a problem hiding this comment.
Thanks, this overall looks reasonable! I think it might make sense for it to be a preview-only change first, though, since it increases the scope of the rule. We also need to update the docs for the rule, which currently just says that the rule
Checks for uses of the builtin open() function without an associated context manager.
crates/ruff_linter/resources/test/fixtures/flake8_simplify/SIM115.py
Outdated
Show resolved
Hide resolved
crates/ruff_linter/src/rules/flake8_simplify/rules/open_file_with_context_handler.rs
Outdated
Show resolved
Hide resolved
AlexWaygood
reviewed
Aug 18, 2024
crates/ruff_linter/src/rules/flake8_simplify/rules/open_file_with_context_handler.rs
Outdated
Show resolved
Hide resolved
MichaReiser
added
rule
diceroll123
force-pushed
the
extend-SIM115-to-tempfile
branch
from
5e54c64
to
3c7b23e
Compare
|
Looking at the ecosystem results: a lot of them seem to be regarding (I'll push some fixes to address this) |
AlexWaygood
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks @diceroll123! I'll wait to check the final ecosystem report before merging, but this LGTM now.
AlexWaygood
changed the title
flake8-simplify] - extend open-file-with-context-handler to work with tempfile (SIM115)flake8-simplify] Extend open-file-with-context-handler to work with other standard-library IO modules (SIM115)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7313
Test Plan
cargo test