Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rule name rather than message in --statistics #11697

Merged
merged 2 commits into from
Jun 24, 2024
Merged

Use rule name rather than message in --statistics #11697

merged 2 commits into from
Jun 24, 2024

Conversation

charliermarsh
Copy link
Member

Summary

Since this changes the output schema of the JSON format for --statistics, let's include it in v0.5.0.

Closes #11097.

@charliermarsh charliermarsh added breaking Breaking API change cli Related to the command-line interface labels Jun 2, 2024
@charliermarsh charliermarsh added this to the v0.5.0 milestone Jun 2, 2024
@zanieb zanieb self-requested a review June 2, 2024 18:29
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 2, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser changed the base branch from main to ruff-0.5 June 24, 2024 12:00
@MichaReiser MichaReiser merged commit 7096340 into ruff-0.5 Jun 24, 2024
20 checks passed
@MichaReiser MichaReiser deleted the charlie/name branch June 24, 2024 12:23
@MichaReiser MichaReiser mentioned this pull request Jun 26, 2024
Merged
MichaReiser pushed a commit that referenced this pull request Jun 27, 2024
@charliermarsh @MichaReiser
Use rule name rather than message in --statistics (#11697)
9b99d81 
Co-authored-by: Micha Reiser <micha@reiser.io>
Closes #11097.
MichaReiser pushed a commit that referenced this pull request Jun 27, 2024
@charliermarsh @MichaReiser
Use rule name rather than message in --statistics (#11697)
bfe36b9 
Co-authored-by: Micha Reiser <micha@reiser.io>
Closes #11097.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila dhruvmanila left review comments

@MichaReiser MichaReiser MichaReiser approved these changes

@zanieb zanieb Awaiting requested review from zanieb

Assignees
No one assigned
Labels
breaking Breaking API change cli Related to the command-line interface
Projects
None yet
Milestone
v0.5.0
Development

Successfully merging this pull request may close these issues.

idea: add generic name to rule violations if message contains formatted strings when output in --statistics
3 participants
@charliermarsh @MichaReiser @dhruvmanila