Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vim and Kate setup guide for ruff server #11615

Merged
merged 8 commits into from
May 31, 2024
Merged

Add Vim and Kate setup guide for ruff server #11615

merged 8 commits into from
May 31, 2024

Conversation

JaRoSchm
Copy link
Contributor

Summary

In the roadmap for ruff server support for vim and kate is listed. Therefore I added setup guides for them based on the neovim guide. As I don't use pyright I wasn't able to translate the corresponding part from the neovim guide.

Test Plan

Doesn't apply.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed some minor nits, and apart from that one question this is good to go. Thank you for working on this!

endfunction
```

If you'd like to use Ruff exclusively for linting, formatting, and import organization, you can disable those capabilities for Pyright.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this requires an example configuration? Do you have that? If not, we can remove this part.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took that from the Neovim setup guide. However, as noted in my post above, I don't use pyright personally, so I am not able to translate this part.

I am using ruff server in combination with pylsp. If this is helpful for someone, I could add the configuration necessary for this combination.

@dhruvmanila dhruvmanila added the documentation Improvements or additions to documentation label May 31, 2024
@dhruvmanila dhruvmanila changed the title DOCS: Add vim and kate setup to ruff server Add Vim and Kate setup guide for ruff server May 31, 2024
Copy link
Member

@charliermarsh charliermarsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@charliermarsh charliermarsh enabled auto-merge (squash) May 31, 2024 19:04
@charliermarsh charliermarsh merged commit 7ce17b7 into astral-sh:main May 31, 2024
18 checks passed
@JaRoSchm JaRoSchm deleted the server-vim-kate-setup branch May 31, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants