Simplify arithmetic operation in logical lines checker #11346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zanieb
approved these changes
May 8, 2024
charliermarsh
approved these changes
May 9, 2024
|
Yeah that's interesting, hmm... Maybe it evolved over time? Maybe this was just the way they thought about the logic? |
| @@ -24,7 +24,7 @@ pub(crate) fn expand_indent(line: &str, indent_width: IndentWidth) -> usize { | |||
| let tab_size = indent_width.as_usize(); | |||
| for c in line.bytes() { | |||
| match c { | |||
| b'\t' => indent = (indent / tab_size) * tab_size + tab_size, | |||
There was a problem hiding this comment.
Wait sorry, is this the same? What if indent is 4 and tab_size is 3?
indent += tab_size would yield 7, but indent = (indent / tab_size) * tab_size + tab_size would yield 6, right?
There was a problem hiding this comment.
I.e., is the goal here perhaps that indent ends up as a multiple of tab_size?
There was a problem hiding this comment.
Is the deal here that there's implicit integer rounding?
There was a problem hiding this comment.
If so, can we add a comment explaining the deal? @charliermarsh
charliermarsh
added a commit
that referenced
this pull request
May 9, 2024
This reverts commit e9d1cdd.
charliermarsh
added a commit
that referenced
this pull request
May 9, 2024
…" (#11348) ## Summary I merged this, but I think it might not be the same behavior? See my comment at: #11346 (comment)
dhruvmanila
pushed a commit
that referenced
this pull request
May 17, 2024
## Summary Simplify arithmetic operation in logical lines checker
dhruvmanila
pushed a commit
that referenced
this pull request
May 17, 2024
…" (#11348) ## Summary I merged this, but I think it might not be the same behavior? See my comment at: #11346 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Simplify arithmetic operation in logical lines checker