F401 - Recommend adding unused import bindings to `all`#11314

Merged

plredmond merged 49 commits intomainfrom ruff.__all__

May 15, 2024

+414-67

Commits on May 14, 2024

Revert "patch to remove the unfinished dunder_all mutation"
plredmond
committed
charlie patch w/proto dunder_all finder
plredmond
committed
find_dunder_all_expr implemented
plredmond
committed
pass ExprList to fix_by_reexporting
plredmond
committed
slight cleanup of branch arms readability
plredmond
committed
rename F401_25__all fixture test to F401_25__all_nonempty
plredmond
committed
remove unnecessary pattern match
plredmond
committed
new field in ImportBinding which is the name of the binding
plredmond
committed
change fix_bind_reexporting call add_to_dunder_all with the list of binding names, /not import member_names/ to fix bug handling renamed imports; also to use a slice imput (per micha)
plredmond
committed
uncomment and review test cases for F401_25 fixture test
plredmond
committed
add edit to insert binding names into __all__
plredmond
committed
fixture tests to more thoroughly explore the cases of the "add to __all__" feature
plredmond
committed
cargo clippy edits -- map..or to map_or and single-pattern match to if..let
plredmond
committed
include the binding name in UnusedImport; when it is not the suffix of the qualified name, use the binding name in the fix title
plredmond
committed
accept fixture test changes that show the binding when it differs from the qualified name
plredmond
committed
accept stylist argument to place correct quotes around binders added to __all__; use "]".text_len() instead of specifying a TextSize manually
plredmond
committed
use Expr instead of ExprList to convey dunder_all value to the edit-producing function b/c we want to also support tuples
plredmond
committed
clippy again
plredmond
committed
change make_redundant_alias to take an iter of Cow to simplify caller
plredmond
committed
rewrite add_to_dunder_all and its tests
plredmond
committed
shakes fist at cloud and yells, "Clippy!!!"
plredmond
committed
change message for redundant-aliases
plredmond
committed
use binding method instead of accessing the field
plredmond
committed
use filter_map followed by last to obtain the first __all__ binding
plredmond
committed
update fixture test to reflect that we add to the first binding of __all__
plredmond
committed
fixture test to demonstrate how we treat __all__ followed by a conditional mutation
plredmond
committed
do not offer a fix to add to __all__ when there is more than one __all__; fall back to the redundant-alias recommending behavior
plredmond
committed
delete F401_29 fixture test
plredmond
committed
rename F401_30 fixture test to F401_29
plredmond
committed
add unused-import case to F401_29 fixture test
plredmond
committed
change find_dunder_all_expr to find_dunder_all_exprs and track the number of matches on UnusedImportContext::Init; update fix-title messaging and fix_by_reexporting to only fix when zero or one…
plredmond
committed
change find_dunder_all_exprs to return /all/ such exprs regardless of their types; the add_to_dunder_all fix-producing function will still only produce fixes for lists & tuples; update fixture test…
plredmond
committed
change fix-title for redundant alias case to format itself and return early
plredmond
committed
use if-let instead of match with empty branch per alex

plredmond
and
AlexWaygood
committed
Update crates/ruff_linter/src/fix/edits.rs

plredmond
and
AlexWaygood
committed
wording improvement per alex

plredmond
and
AlexWaygood
committed
replace into::Into with Cow::from to make conversion explicit
plredmond
committed
improve the wording of "add unused import to __all__" message per alex
plredmond
committed
reformat a function -- noop w.r.t. the tests
plredmond
committed
remove a now unnecessary branch, which also makes the overall PR diff smaller
plredmond
committed
call .end() directly instead of going through .range or .range(); remove unnecessary import paths
plredmond
committed
readd erroneously removed newlines to fixture snaps
plredmond
committed
ruff format the fixture __init__.py files
plredmond
committed
cargo insta review -- accept whitespace changes (see git diff -w)
plredmond
committed
clippy fix -- replace closure with static reference to method
plredmond
committed
collect only 2 __all__ definitions and then stop pulling the iterator

plredmond
and
AlexWaygood
authored
Revert "collect only 2 __all__ definitions and then stop pulling the iterator"
plredmond
committed
remove the qualified-name field from UnusedImport in favor of the binding-name field (named as .name); update fixture test results
plredmond
committed
Revert "remove the qualified-name field from UnusedImport in favor of the binding-name field (named as .name); update fixture test results"
plredmond
committed