Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing space from CapWords message #10220

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Remove trailing space from CapWords message #10220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/ruff/tests/lint.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,7 +849,7 @@ fn deprecated_config_option_overridden_via_cli() {
success: false
exit_code: 1
----- stdout -----
-:1:7: N801 Class name `lowercase` should use CapWords convention
-:1:7: N801 Class name `lowercase` should use CapWords convention
Found 1 error.

----- stderr -----
Expand Down
2 changes: 1 addition & 1 deletion crates/ruff_linter/src/rules/pep8_naming/rules/invalid_class_name.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ impl Violation for InvalidClassName {
#[derive_message_formats]
fn message(&self) -> String {
let InvalidClassName { name } = self;
format!("Class name `{name}` should use CapWords convention ")
format!("Class name `{name}` should use CapWords convention")
}
}

Expand Down
12 changes: 5 additions & 7 deletions ...src/rules/pep8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__N801_N801.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,39 +1,37 @@
---
source: crates/ruff_linter/src/rules/pep8_naming/mod.rs
---
N801.py:1:7: N801 Class name `bad` should use CapWords convention
N801.py:1:7: N801 Class name `bad` should use CapWords convention
|
1 | class bad:
| ^^^ N801
2 | pass
|

N801.py:5:7: N801 Class name `_bad` should use CapWords convention
N801.py:5:7: N801 Class name `_bad` should use CapWords convention
|
5 | class _bad:
| ^^^^ N801
6 | pass
|

N801.py:9:7: N801 Class name `bad_class` should use CapWords convention
N801.py:9:7: N801 Class name `bad_class` should use CapWords convention
|
9 | class bad_class:
| ^^^^^^^^^ N801
10 | pass
|

N801.py:13:7: N801 Class name `Bad_Class` should use CapWords convention
N801.py:13:7: N801 Class name `Bad_Class` should use CapWords convention
|
13 | class Bad_Class:
| ^^^^^^^^^ N801
14 | pass
|

N801.py:17:7: N801 Class name `BAD_CLASS` should use CapWords convention
N801.py:17:7: N801 Class name `BAD_CLASS` should use CapWords convention
|
17 | class BAD_CLASS:
| ^^^^^^^^^ N801
18 | pass
|


6 changes: 2 additions & 4 deletions ...8_naming/snapshots/ruff_linter__rules__pep8_naming__tests__ignore_names_N801_N801.py.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
source: crates/ruff_linter/src/rules/pep8_naming/mod.rs
---
N801.py:4:7: N801 Class name `stillBad` should use CapWords convention
N801.py:4:7: N801 Class name `stillBad` should use CapWords convention
|
2 | pass
3 |
Expand All @@ -10,13 +10,11 @@ N801.py:4:7: N801 Class name `stillBad` should use CapWords convention
5 | pass
|

N801.py:10:7: N801 Class name `STILL_BAD` should use CapWords convention
N801.py:10:7: N801 Class name `STILL_BAD` should use CapWords convention
|
8 | pass
9 |
10 | class STILL_BAD:
| ^^^^^^^^^ N801
11 | pass
|


Loading