Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecosystem check for indico #10164

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Fix ecosystem check for indico #10164

merged 1 commit into from
Feb 29, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Feb 29, 2024

Summary

Remove the S410 rule from the indico ecosystem check

@MichaReiser MichaReiser added the ci Related to internal CI tooling label Feb 29, 2024
@MichaReiser MichaReiser force-pushed the fix-ecosystem-check branch 2 times, most recently from 8a14243 to 78ff9f0 Compare February 29, 2024 08:50
@MichaReiser MichaReiser marked this pull request as ready for review February 29, 2024 09:01
# Remove once indico removed S401 from their ignore configuration
config_overrides={
"lint.ignore": [
"E226", # allow omitting whitespace around arithmetic operators
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit silly but I couldn't find a way to remove a single rule from ignore

Copy link
Contributor

github-actions bot commented Feb 29, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

Formatter (stable)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

Formatter (preview)

ℹ️ ecosystem check encountered format errors. (no format changes; 1 project error)

openai/openai-cookbook (error)

ruff format --preview

warning: Detected debug build without --no-cache.
error: Failed to read examples/How_to_handle_rate_limits.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: trailing comma at line 47 column 4

@MichaReiser MichaReiser merged commit 72ccb34 into main Feb 29, 2024
17 checks passed
@MichaReiser MichaReiser deleted the fix-ecosystem-check branch February 29, 2024 09:27
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to internal CI tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant