Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support glob patterns in pep8-naming’s ignore-names option. #2787

Closed
manueljacob opened this issue Feb 12, 2023 · 1 comment · Fixed by #5024
Closed

Support glob patterns in pep8-naming’s ignore-names option. #2787

manueljacob opened this issue Feb 12, 2023 · 1 comment · Fixed by #5024
Assignees
@Thomasdezeeuw
Labels
configuration Related to settings and configuration

Comments

@manueljacob
Copy link
Contributor

The original pep8-naming supports glob patterns in the ignore-names option. Currently, Ruff supports only fixed strings.
@charliermarsh charliermarsh added the configuration Related to settings and configuration label Feb 12, 2023
@ergoithz
Copy link

ergoithz commented May 25, 2023 •
edited
Loading

Just wanted to point out this would be required to effectively support custom unittest-style assert* methods.

Without this feature, the only alternatives are either disabling N802 entirely or manually add every single custom assertion method name as ignore-names.

@JonathanPlasse JonathanPlasse mentioned this issue May 29, 2023
Closed
@Thomasdezeeuw Thomasdezeeuw self-assigned this Jun 12, 2023
@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jun 12, 2023
Merged
Thomasdezeeuw pushed a commit that referenced this issue Jun 13, 2023
Support glob patterns in pep8_naming ignore-names (#5024)
b0f89fa 
## Summary

 Support glob patterns in pep8_naming ignore-names.

Closes #2787

## Test Plan

Added new tests.
@niklasmohrin niklasmohrin mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thomasdezeeuw Thomasdezeeuw

Labels
configuration Related to settings and configuration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support glob patterns in pep8_naming ignore-names astral-sh/ruff
4 participants
@charliermarsh @Thomasdezeeuw @ergoithz @manueljacob