UP028 for multiple loops does not work

[spaceby]

UP028 does not work when there are multiple yield loops in a function

Code example:

def text_not_ok():
    a = [1, 2, 3]
    for photo in a:
        yield photo
    for photo in a:
        yield photo

https://play.ruff.rs/b9748aaf-8e8c-45cd-8138-20f41013b979

[AlexWaygood]

I think this is because of this logic here:

ruff/crates/ruff_linter/src/rules/pyupgrade/rules/yield_in_for_loop.rs

Lines 98 to 112 in c3bcd5c

	// If any of the bound names are used outside of the yield itself, don't rewrite.
	if collect_names(value).any(|name| {
	checker
	.semantic()
	.current_scope()
	.get_all(name.id.as_str())
	.any(|binding_id| {
	let binding = checker.semantic().binding(binding_id);
	binding.references.iter().any(|reference_id| {
	checker.semantic().reference(*reference_id).range() != name.range()
	})
	})
	}) {
	return;
	}

I.e., Ruff believes that some of the variables bound by the first loop might be referenced in the second loop, so it comes to the conclusion that it won't necessarily be safe to rewrite them as yield from statements. If you change the second loop to use different variable names, it flags both loops with UP028: https://play.ruff.rs/50ee023e-60f4-4a77-a870-3378a6c68b72

It would be possible to improve Ruff's behaviour here, I think, but it might add some complexity to our implementation

[spaceby]

Then you need to improve ruff's behavior
Or add another rule that tracks repeating loops
Or add a warning about this behavior to the documentation