fixup! [red-knot] feat: introduce a new [Type::Todo] variant

astral-sh · Sep 29, 2024 · da90894 · da90894
1 parent d620d0e
commit da90894
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/crates/red_knot_python_semantic/src/types.rs b/crates/red_knot_python_semantic/src/types.rs
@@ -511,7 +511,7 @@ impl<'db> Type<'db> {
                 // TODO raise error
                 Type::Todo
             }
-            Type::BooleanLiteral(_) => Type::Unknown,
+            Type::BooleanLiteral(_) => Type::Todo,
             Type::StringLiteral(_) => {
                 // TODO defer to `typing.LiteralString`/`builtins.str` methods
                 // from typeshed's stubs

diff --git a/crates/red_knot_python_semantic/src/types/infer.rs b/crates/red_knot_python_semantic/src/types/infer.rs
@@ -1920,7 +1920,6 @@ impl<'db> TypeInferenceBuilder<'db> {
         is_async: bool,
         definition: Definition<'db>,
     ) {
-        println!("=> infer comprehension");
         let expression = self.index.expression(iterable);
         let result = infer_expression_types(self.db, expression);
 
@@ -1942,8 +1941,6 @@ impl<'db> TypeInferenceBuilder<'db> {
             result.expression_ty(iterable.scoped_ast_id(self.db, self.scope))
         };
 
-        println!("=> iterable_ty: {:?}", iterable_ty.display(self.db));
-
         let target_ty = if is_async {
             // TODO: async iterables/iterators! -- Alex
             Type::Todo