Skip to content

Commit

Permalink
Add Applicability to isort (#5161)
Browse files Browse the repository at this point in the history
## Summary

Fixes some of #4184.
  • Loading branch information
evanrittenhouse authored Jun 17, 2023
1 parent f18e101 commit 95448ba
Show file tree
Hide file tree
Showing 12 changed files with 14 additions and 15 deletions.
3 changes: 1 addition & 2 deletions crates/ruff/src/rules/isort/rules/add_required_imports.rs
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,7 @@ fn add_required_import(
TextRange::default(),
);
if settings.rules.should_fix(Rule::MissingRequiredImport) {
#[allow(deprecated)]
diagnostic.set_fix(Fix::unspecified(
diagnostic.set_fix(Fix::automatic(
Importer::new(python_ast, locator, stylist)
.add_import(required_import, TextSize::default()),
));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ docstring.py:1:1: I002 [*] Missing required import: `from __future__ import anno
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+from __future__ import annotations
2 3 |
Expand All @@ -25,7 +25,7 @@ docstring.py:1:1: I002 [*] Missing required import: `from __future__ import gene
|
= help: Insert required import: `from future import generator_stop`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+from __future__ import generator_stop
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ comment.py:1:1: I002 [*] Missing required import: `from __future__ import annota
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | #!/usr/bin/env python3
2 |+from __future__ import annotations
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ docstring.py:1:1: I002 [*] Missing required import: `from __future__ import anno
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+from __future__ import annotations
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ docstring_with_continuation.py:1:1: I002 [*] Missing required import: `from __fu
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 |-"""Hello, world!"""; x = \
1 |+"""Hello, world!"""; from __future__ import annotations; x = \
2 2 | 1; y = 2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ docstring_with_semicolon.py:1:1: I002 [*] Missing required import: `from __futur
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 |-"""Hello, world!"""; x = 1
1 |+"""Hello, world!"""; from __future__ import annotations; x = 1

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ existing_import.py:1:1: I002 [*] Missing required import: `from __future__ impor
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 |+from __future__ import annotations
1 2 | from __future__ import generator_stop
2 3 | import os
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ multiline_docstring.py:1:1: I002 [*] Missing required import: `from __future__ i
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | """a
2 2 | b"""
3 3 | # b
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ off.py:1:1: I002 [*] Missing required import: `from __future__ import annotation
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | # isort: off
2 |+from __future__ import annotations
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ docstring.py:1:1: I002 [*] Missing required import: `from __future__ import anno
|
= help: Insert required import: `from future import annotations`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+from __future__ import annotations
2 3 |
Expand All @@ -25,7 +25,7 @@ docstring.py:1:1: I002 [*] Missing required import: `from __future__ import gene
|
= help: Insert required import: `from future import generator_stop`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+from __future__ import generator_stop
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ docstring.py:1:1: I002 [*] Missing required import: `import os`
|
= help: Insert required import: `import os`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+import os
2 3 |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ docstring.pyi:1:1: I002 [*] Missing required import: `import os`
|
= help: Insert required import: `import os`

Suggested fix
Fix
1 1 | """Hello, world!"""
2 |+import os
2 3 |
Expand Down

0 comments on commit 95448ba

Please sign in to comment.