-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[red-knot] Add fuzzer to catch panics for invalid syntax
- Loading branch information
1 parent
f1b2e85
commit 94698f8
Showing
5 changed files
with
175 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| ruff_fix_validity |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,131 @@ | ||
| //! Fuzzer harness that runs the type checker to catch for panics for source code containing | ||
| //! syntax errors. | ||
| #![no_main] | ||
|
|
||
| use libfuzzer_sys::{fuzz_target, Corpus}; | ||
|
|
||
| use red_knot_python_semantic::types::check_types; | ||
| use red_knot_python_semantic::{ | ||
| Db as SemanticDb, Program, ProgramSettings, PythonVersion, SearchPathSettings, | ||
| }; | ||
| use ruff_db::files::{system_path_to_file, File, Files}; | ||
| use ruff_db::system::{DbWithTestSystem, System, SystemPathBuf, TestSystem}; | ||
| use ruff_db::vendored::VendoredFileSystem; | ||
| use ruff_db::{Db as SourceDb, Upcast}; | ||
| use ruff_python_parser::{parse_unchecked, Mode}; | ||
|
|
||
| /// Database that can be used for testing. | ||
| /// | ||
| /// Uses an in memory filesystem and it stubs out the vendored files by default. | ||
| #[salsa::db] | ||
| struct TestDb { | ||
| storage: salsa::Storage<Self>, | ||
| files: Files, | ||
| system: TestSystem, | ||
| vendored: VendoredFileSystem, | ||
| events: std::sync::Arc<std::sync::Mutex<Vec<salsa::Event>>>, | ||
| } | ||
|
|
||
| impl TestDb { | ||
| fn new() -> Self { | ||
| Self { | ||
| storage: salsa::Storage::default(), | ||
| system: TestSystem::default(), | ||
| vendored: red_knot_vendored::file_system().clone(), | ||
| events: std::sync::Arc::default(), | ||
| files: Files::default(), | ||
| } | ||
| } | ||
| } | ||
|
|
||
| #[salsa::db] | ||
| impl SourceDb for TestDb { | ||
| fn vendored(&self) -> &VendoredFileSystem { | ||
| &self.vendored | ||
| } | ||
|
|
||
| fn system(&self) -> &dyn System { | ||
| &self.system | ||
| } | ||
|
|
||
| fn files(&self) -> &Files { | ||
| &self.files | ||
| } | ||
| } | ||
|
|
||
| impl DbWithTestSystem for TestDb { | ||
| fn test_system(&self) -> &TestSystem { | ||
| &self.system | ||
| } | ||
|
|
||
| fn test_system_mut(&mut self) -> &mut TestSystem { | ||
| &mut self.system | ||
| } | ||
| } | ||
|
|
||
| impl Upcast<dyn SourceDb> for TestDb { | ||
| fn upcast(&self) -> &(dyn SourceDb + 'static) { | ||
| self | ||
| } | ||
| fn upcast_mut(&mut self) -> &mut (dyn SourceDb + 'static) { | ||
| self | ||
| } | ||
| } | ||
|
|
||
| #[salsa::db] | ||
| impl SemanticDb for TestDb { | ||
| fn is_file_open(&self, file: File) -> bool { | ||
| !file.path(self).is_vendored_path() | ||
| } | ||
| } | ||
|
|
||
| #[salsa::db] | ||
| impl salsa::Database for TestDb { | ||
| fn salsa_event(&self, event: &dyn Fn() -> salsa::Event) { | ||
| let event = event(); | ||
| tracing::trace!("event: {:?}", event); | ||
| let mut events = self.events.lock().unwrap(); | ||
| events.push(event); | ||
| } | ||
| } | ||
|
|
||
| fn setup_db() -> TestDb { | ||
| let db = TestDb::new(); | ||
|
|
||
| let src_root = SystemPathBuf::from("/src"); | ||
| db.memory_file_system() | ||
| .create_directory_all(&src_root) | ||
| .unwrap(); | ||
|
|
||
| Program::from_settings( | ||
| &db, | ||
| &ProgramSettings { | ||
| target_version: PythonVersion::default(), | ||
| search_paths: SearchPathSettings::new(src_root), | ||
| }, | ||
| ) | ||
| .expect("Valid search path settings"); | ||
|
|
||
| db | ||
| } | ||
|
|
||
| fn do_fuzz(case: &[u8]) -> Corpus { | ||
| let Ok(code) = std::str::from_utf8(case) else { | ||
| return Corpus::Reject; | ||
| }; | ||
|
|
||
| let parsed = parse_unchecked(code, Mode::Module); | ||
| if parsed.is_valid() { | ||
| return Corpus::Reject; | ||
| } | ||
|
|
||
| let mut db = setup_db(); | ||
| db.write_file("/src/a.py", code).unwrap(); | ||
| let file = system_path_to_file(&db, "/src/a.py").unwrap(); | ||
| check_types(&db, file); | ||
|
|
||
| Corpus::Keep | ||
| } | ||
|
|
||
| fuzz_target!(|case: &[u8]| -> Corpus { do_fuzz(case) }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters