Fix end location for elif blocks

Since we parse an `elif:` block as an `If` node, its location should include its `orelse` node like it would for an `if:` block. Signed-off-by: Anders Kaseorg <andersk@mit.edu>
astral-sh · Jan 18, 2023 · 6dba843 · 6dba843
1 parent b26365b
commit 6dba843
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/parser/python.lalrpop b/parser/python.lalrpop
@@ -372,7 +372,7 @@ IfStatement: ast::Stmt = {
             let x = ast::Stmt {
                 custom: (),
                 location: i.0,
-                end_location: i.4.last().unwrap().end_location,
+                end_location,
                 node: ast::StmtKind::If { test: Box::new(i.2), body: i.4, orelse: last },
             };
             last = vec![x];

diff --git a/parser/src/snapshots/rustpython_parser__parser__tests__parse_if_elif_else.snap b/parser/src/snapshots/rustpython_parser__parser__tests__parse_if_elif_else.snap
@@ -79,8 +79,8 @@ expression: parse_ast
                     },
                     end_location: Some(
                         Location {
-                            row: 2,
-                            column: 10,
+                            row: 3,
+                            column: 8,
                         },
                     ),
                     custom: (),