HashSet

astral-sh · Nov 3, 2023 · 54387be · 54387be
1 parent 4425b78
commit 54387be
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/crates/ruff_linter/src/rules/flake8_pie/rules/unnecessary_dict_kwargs.rs b/crates/ruff_linter/src/rules/flake8_pie/rules/unnecessary_dict_kwargs.rs
@@ -1,3 +1,5 @@
+use std::collections::HashSet;
+
 use itertools::Itertools;
 use ruff_diagnostics::{AlwaysFixableViolation, Diagnostic, Edit, Fix};
 use ruff_python_ast::{self as ast, Expr, Keyword};
@@ -53,12 +55,12 @@ impl AlwaysFixableViolation for UnnecessaryDictKwargs {
 
 /// PIE804
 pub(crate) fn unnecessary_dict_kwargs(checker: &mut Checker, expr: &Expr, kwargs: &[Keyword]) {
-    let mut all_kwargs = Vec::new();
+    let mut all_kwargs = HashSet::new();
 
     for kw in kwargs {
         // keyword is a spread operator (indicated by None)
         if let Some(name) = &kw.arg {
-            all_kwargs.push(name.as_str());
+            all_kwargs.insert(name.as_str());
             continue;
         }
 
@@ -88,7 +90,7 @@ pub(crate) fn unnecessary_dict_kwargs(checker: &mut Checker, expr: &Expr, kwargs
                 if all_kwargs.contains(name) {
                     false
                 } else {
-                    all_kwargs.push(name);
+                    all_kwargs.insert(name);
                     true
                 }
             })