Skip to content

Commit

Permalink
[red-knot] Re-enable linter corpus tests (#14736)
Browse files Browse the repository at this point in the history
## Summary

Seeing the fuzzing results from @dhruvmanila in #13778, I think we can
re-enable these tests. We also had one regression that would have been
caught by these tests, so there is some value in having them enabled.
  • Loading branch information
sharkdp authored Dec 2, 2024
1 parent 83651de commit 5137fcc
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions crates/red_knot_workspace/tests/check.rs
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ fn parser_no_panic() -> anyhow::Result<()> {
}

#[test]
#[ignore = "Enable running once there are fewer failures"]
fn linter_af_no_panic() -> anyhow::Result<()> {
let workspace_root = get_workspace_root()?;
run_corpus_tests(&format!(
Expand All @@ -51,7 +50,6 @@ fn linter_af_no_panic() -> anyhow::Result<()> {
}

#[test]
#[ignore = "Enable running once there are fewer failures"]
fn linter_gz_no_panic() -> anyhow::Result<()> {
let workspace_root = get_workspace_root()?;
run_corpus_tests(&format!(
Expand Down Expand Up @@ -272,6 +270,7 @@ const KNOWN_FAILURES: &[(&str, bool, bool)] = &[
("crates/ruff_linter/resources/test/fixtures/pyupgrade/UP039.py", true, false),
// related to circular references in type aliases (salsa cycle panic):
("crates/ruff_python_parser/resources/inline/err/type_alias_invalid_value_expr.py", true, true),
("crates/ruff_linter/resources/test/fixtures/flake8_type_checking/TC008.py", true, true),
// related to circular references in f-string annotations (invalid syntax)
("crates/ruff_linter/resources/test/fixtures/pyflakes/F821_15.py", true, true),
("crates/ruff_linter/resources/test/fixtures/pyflakes/F821_14.py", false, true),
Expand Down

0 comments on commit 5137fcc

Please sign in to comment.