Avoid boolean-trap rules for ConfigParser get() methods (#3209)

astral-sh · Feb 24, 2023 · 24add5f · 24add5f
1 parent 0b7736a
commit 24add5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py b/crates/ruff/resources/test/fixtures/flake8_boolean_trap/FBT.py
@@ -59,6 +59,10 @@ def used(do):
 mylist.index(True)
 int(True)
 str(int(False))
+cfg.get("hello", True)
+cfg.getint("hello", True)
+cfg.getfloat("hello", True)
+cfg.getboolean("hello", True)
 
 
 class Registry:

diff --git a/crates/ruff/src/rules/flake8_boolean_trap/rules.rs b/crates/ruff/src/rules/flake8_boolean_trap/rules.rs
@@ -56,6 +56,9 @@ const FUNC_CALL_NAME_ALLOWLIST: &[&str] = &[
     "bytes",
     "int",
     "float",
+    "getint",
+    "getfloat",
+    "getboolean",
 ];
 
 const FUNC_DEF_NAME_ALLOWLIST: &[&str] = &["__setitem__"];

diff --git a/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap b/...flake8_boolean_trap/snapshots/ruff__rules__flake8_boolean_trap__tests__FBT001_FBT.py.snap
@@ -85,10 +85,10 @@ expression: diagnostics
 - kind:
     BooleanPositionalArgInFunctionDefinition: ~
   location:
-    row: 77
+    row: 81
     column: 18
   end_location:
-    row: 77
+    row: 81
     column: 29
   fix: ~
   parent: ~