Improve development experience #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
reviewed
May 16, 2023
README.md
Outdated
|
|
||
| - Clone the [ruff-lsp](https://github.com/charliermarsh/ruff-lsp) to e.g. `../ruff-lsp` | ||
| - Go to `../ruff-lsp` and run `pip install -t ../ruff-vscode/bundled/libs/ -e .` | ||
| - If you want to use a custom ruff build, copy or link it to `bundles/libs/bin/ruff` |
There was a problem hiding this comment.
You can also change the path in the extension settings
| # Don't repeat every message | ||
| "pygls.protocol": { | ||
| "level": "WARN", | ||
| "handlers": ["stderr"], |
There was a problem hiding this comment.
Is my assumption correct that this writes to stderr and not the output pane?
There was a problem hiding this comment.
It also writes to the output pane just in red instead of blue
There was a problem hiding this comment.
Oh nice. Is this because the vs code extension redirects stderr to the output panel?
There was a problem hiding this comment.
yes, i think they generally just gather all output
charliermarsh
changed the title
|
Will use this opportunity to annoyingly comment on a couple procedural nits:
|
|
Will do! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal improvements that making working on the extension easier: