Support one-based column indices for Edits #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff is switching to use one-based column indices for edits to align them with the fix-column indices.
This PR converts the column indices to zero-based indices depending on the connected ruff version. The heuristic used to detect whether ruff uses one-based indices is to test if the
Fix
has anapplicability
field which was newly introduced in astral-sh/ruff#4341.Test Plan
New ruff version
https://github.com/charliermarsh/ruff-lsp/assets/1203881/25f8ef9c-5215-4126-8dfb-4aa48fee9dbe
old ruff version using zero-based column indices
https://github.com/charliermarsh/ruff-lsp/assets/1203881/172cd901-7c70-47e8-81fa-f9c1402c69b1