-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support requirements.txt for version-file #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
A few changes and we are good to go.
Don't forget to run npm run all
so it creates the distribution.
b15526a
to
bb5308c
Compare
I addressed all of the feedback and it should be ready to go |
I have no experience packaging actions, so just out of curiosity, is the bundling of |
#72 was merged. Can you please rebase? |
bda9f4a
to
15b1a34
Compare
Rebased and version changed |
15b1a34
to
ead9c6d
Compare
Does |
Looks like a |
I ran it and nothing had changed. I just tried again and still nothing was different, so I'm not sure what to do there. |
Can you rebase on main? You might be missing changes which get merged in the CI build |
I hadn't run |
Ah right I always forget about this! |
Maybe add it to |
Thanks! |
No description provided.