Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support requirements.txt for version-file #68

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

daveisfera
Copy link
Contributor

No description provided.

@daveisfera daveisfera requested a review from eifinger as a code owner February 1, 2025 05:03
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution!

A few changes and we are good to go.

Don't forget to run npm run all so it creates the distribution.

@daveisfera daveisfera force-pushed the version-file_requirements branch from b15526a to bb5308c Compare February 1, 2025 16:56
@daveisfera
Copy link
Contributor Author

I addressed all of the feedback and it should be ready to go

@daveisfera
Copy link
Contributor Author

Don't forget to run npm run all so it creates the distribution.

I have no experience packaging actions, so just out of curiosity, is the bundling of dist/index.js necessary? It feels like that should be a build/deploy step and not something that's checked into the repo.

@eifinger
Copy link
Collaborator

eifinger commented Feb 6, 2025

#72 was merged. Can you please rebase?

@daveisfera daveisfera force-pushed the version-file_requirements branch from bda9f4a to 15b1a34 Compare February 6, 2025 13:59
@daveisfera
Copy link
Contributor Author

Rebased and version changed

@daveisfera daveisfera force-pushed the version-file_requirements branch from 15b1a34 to ead9c6d Compare February 6, 2025 14:03
@daveisfera
Copy link
Contributor Author

Does src need to be set to anything special? The test failed because it wants to reformat files, so does it need to be in it's own sub-directory and have src set to that?

@eifinger
Copy link
Collaborator

eifinger commented Feb 6, 2025

Looks like a npm run all is missing and we are good to go

@daveisfera
Copy link
Contributor Author

I ran it and nothing had changed. I just tried again and still nothing was different, so I'm not sure what to do there.

@eifinger
Copy link
Collaborator

eifinger commented Feb 6, 2025

Can you rebase on main? You might be missing changes which get merged in the CI build

@daveisfera
Copy link
Contributor Author

I hadn't run npm install so that's why it was out of date. Should be good now

@eifinger
Copy link
Collaborator

eifinger commented Feb 6, 2025

I hadn't run npm install so that's why it was out of date. Should be good now

Ah right I always forget about this!

@daveisfera
Copy link
Contributor Author

I hadn't run npm install so that's why it was out of date. Should be good now

Ah right I always forget about this!

Maybe add it to nom run all?

@eifinger
Copy link
Collaborator

eifinger commented Feb 6, 2025

Thanks!

@eifinger eifinger merged commit d8f577d into astral-sh:main Feb 6, 2025
27 checks passed
@eifinger eifinger added the enhancement New feature or request label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants