Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read the [project.optional-dependencies] and [dependency-groups] tables #66

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

AA-Turner
Copy link
Contributor

@AA-Turner AA-Turner commented Jan 31, 2025

I'd quite like to use ruff-action's auto-detection feature, but it currently doesn't read the [project.optional-dependency] table, and support for the PEP 735 [dependency-groups] table is currently limited to only the special-cased dev key, and does not account for the possibility of {include-group="..."} inline tables, as described by the PEP.

I have guessed how to make the tests work, as the only JS development I do is plain JS (sans frameworks), so TypeScript is still quite new to me -- feel free to push required changes to this branch.

A

@AA-Turner AA-Turner requested a review from eifinger as a code owner January 31, 2025 13:23
Copy link
Collaborator

@eifinger eifinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you very much!

@eifinger eifinger added the enhancement New feature or request label Jan 31, 2025
@eifinger eifinger merged commit f14634c into astral-sh:main Jan 31, 2025
25 checks passed
@AA-Turner AA-Turner deleted the optional-dependencies branch January 31, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants