Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip building pythonbuild when not needed #440

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Skip building pythonbuild when not needed #440

merged 3 commits into from
Dec 20, 2024
+56 −5

Conversation

zanieb
Copy link
Member

@zanieb zanieb commented Dec 18, 2024 •
edited
Loading

Only build the Rust pythonbuild crate if one of the following is true

  • We're on main
  • There are builds for the platform
  • There are changes to the .rs files

@zanieb zanieb added platform:linux Specific to the Linux platform ci:dry-run internal A refactor or improvement that is not user-facing platform:windows Specific to the Windows platform and removed platform:linux Specific to the Linux platform labels Dec 18, 2024
@zanieb zanieb force-pushed the zb/skip-pythonbuild branch from d91390a to bb1ae45 Compare December 18, 2024 19:49
@zanieb zanieb requested a review from charliermarsh December 18, 2024 20:43
@zanieb zanieb marked this pull request as ready for review December 18, 2024 21:09
@zanieb zanieb force-pushed the zb/skip-pythonbuild branch from bb1ae45 to ed68382 Compare December 19, 2024 18:12
@zanieb zanieb merged commit 744a0ef into main Dec 20, 2024
22 checks passed
@zanieb zanieb deleted the zb/skip-pythonbuild branch December 20, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliermarsh charliermarsh Awaiting requested review from charliermarsh

Assignees
No one assigned
Labels
ci:dry-run internal A refactor or improvement that is not user-facing platform:windows Specific to the Windows platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zanieb