-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ATM-39: Add Base Theme to Meetup Repo #49
Conversation
perf: abstract default theme perf: temporary color swatches added refactor: move fonts to themes and remove example code refactor: clean up style.css, add postcss refactor: file organization, themes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looks great! I normally wouldn't commit on your branch but I had to add merge conflicts from main & add some configuration for astro to point to the right files. Also ran into snag with Bold
in one of the file names and had some issues getting CI to pass.
I'm curious how the images of swatches / fonts are being made, and if you could add them as an html page on the site?
@ninjaofawesome let me know if this is ready to be merged 👍 |
I actually did it the most hack-tastic way possible by just adding each swatch manually (and then removing it before putting out the PR). How about I make a separate issue for that and get on that next? |
Description
Issue
#39
Notes
primary
,secondary
, andtertiary
colors namedprimaryGradient
,secondaryGradient
, andtertiaryGradient
. These can be renamed for clarity if desired.postCSS
package is needed for imports, but added it so that directives could be imported and used as needed, where needed. Could the reference to thepostCss
package be in thetailwind.config.mjs
file under plugins?autoprefixer
for vendor prefixes. If it feels unnecessary, for now I can remove it.src/styles
directory.How to test
npm run dev
NotoSans
Screenshots
Swatches:
Font Families:
Example of type elements applied on feed: