Add a colab notebook demo, and a separate script. Support from_pretrained for easier use. #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Can you use pre-commit please ? |
|
hi, do you have a link to how to use pre-commit? never used it before
On Sun, May 28, 2023 at 00:48 Pariente Manuel ***@***.***> wrote:
Looks good.
Can you use pre-commit please ?
—
Reply to this email directly, view it on GitHub
<#668 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AF2C6G7FI3IB56ZDQGP3EJTXIIV6JANCNFSM6AAAAAAYP5BD6I>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Joseph Zhu
|
|
You can check here : https://github.com/asteroid-team/asteroid/blob/master/CONTRIBUTING.md#coding-style |
|
I think the "pre-commit" hyperlink in the page linked above doesn't work, but I just ran under asteroid root |
|
The PR has 64 files changed now. SO no, it's not ok. Run it on the files you modified only. |
|
And only python files. |
|
k, I ran instead. Hope this is correct. |
mpariente
reviewed
May 31, 2023
| torchaudio.save(f"outputs/{i}.wav", source[None], sample_rate) | ||
|
|
||
| print( | ||
| "Thank you for using Multi-Decoder-DPRNN to separate your mixture files. Please support our work by citing our paper: http://www.isle.illinois.edu/speech_web_lg/pubs/2021/zhu2021multi.pdf" |
There was a problem hiding this comment.
This line looks too long.
Can you cut the print in half.
Otherwise, the rest is good.
|
ok, i cut it in half |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have been contacting me about not having a pytorch_model.bin file, so I made one, now this model can be loaded with a one-liner