Adopt the moveAssetsInOrder transform from core

[papandreou]

Also, avoid relying on the query compilation by rewriting the queryObj to a predicate function. I think that's much easier to read.

This will allow us to get rid of the moveAssets and moveAssetsInOrder transforms in the next major version of assetgraph 😌

[Munter]

The switch from sift to pure javascript does indeed make it a lot easier to read.

Should we also pull in the tests for the new additions that are moving over? I don't know if the tests for the file hashing part cover enough to guarantee we can avoid regressions

[papandreou]

I don’t think it’s necessary with more tests, it’s just some helper functions, really.

The switch from sift to pure javascript does indeed make it a lot easier to read.

Yeah, makes me wonder if the whole query syntax thing is even worth it. It was always a pretty hard thing to explain. I’m thinking about moving it to some kind of plugin, or maybe just ditching it.

[Munter]

If we ever wanted to supply typescript types for stuff in assetgraph it would certainly be easier to just let people write their own filtering function instead of attempting to make sift typed somehow