Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filtering] Add support for filtering packages like Maven plugin #53

Merged
merged 7 commits into from
Apr 25, 2023

Conversation

Nava2
Copy link
Collaborator

@Nava2 Nava2 commented Apr 25, 2023

This adds package filters similar to how the Maven plugin filters in its <packages> block. This supports ant-like patterns similar to how patterns filter.

Partial implementation of #16.

Nava2 added 3 commits April 25, 2023 10:46
This adds package filters similar to how the Maven plugin filters in its `<packages>` block. This supports ant-like patterns similar to how patterns filter.
import java.util.function.Predicate

@Suppress("UNCHECKED_CAST")
sealed class JavaIdentifierNamePatternFilterableBase<T, SELF>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be reused for the classes block in a follow-up.

}
}

fun setIncludes(includes: Iterable<String>): SELF {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Nava2 Nava2 requested a review from scordio April 25, 2023 15:02
@Nava2 Nava2 changed the title [Filtering] Add support for filtering packages like Maven [Filtering] Add support for filtering packages like Maven plugin Apr 25, 2023
@Nava2 Nava2 merged commit b8acd28 into main Apr 25, 2023
@Nava2 Nava2 deleted the kevin/16/mirror-maven-classes-and-packages branch April 25, 2023 20:29
Nava2 added a commit that referenced this pull request Apr 25, 2023
This adds package filters similar to how the Maven plugin filters in its `<classes>` block. This supports ant-like patterns similar to how patterns filter.

Follows #53 which added similar support for `packages` filtering

Closes #16.
Nava2 added a commit that referenced this pull request Apr 25, 2023
This adds package filters similar to how the Maven plugin filters in its `<classes>` block. This supports ant-like patterns similar to how patterns filter.

Follows #53 which added similar support for `packages` filtering

Closes #16.
Nava2 added a commit that referenced this pull request Apr 25, 2023
This adds package filters similar to how the Maven plugin filters in its `<classes>` block. This supports ant-like patterns similar to how patterns filter.

Follows #53 which added similar support for `packages` filtering

Closes #16.
Nava2 added a commit that referenced this pull request Apr 26, 2023
This adds package filters similar to how the Maven plugin filters in its `<classes>` block. This supports ant-like patterns similar to how patterns filter.

Follows #53 which added similar support for `packages` filtering

Closes #16.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants