Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Simplify] Clean-up and add missing entry point values #39

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

Nava2
Copy link
Collaborator

@Nava2 Nava2 commented Apr 23, 2023

This has some small clean-ups before running Konvert on the EntryPointOptions type.

Extracted from #29

Nava2 added a commit that referenced this pull request Apr 23, 2023
This converts the groovy source into Kotlin and sets up the dependencies accordingly to incrementally convert file-by-file. This does require that Groovy sources depend on Kotlin ones in a unidirectional fashion. This is unfortunate but one-way must be chosen.

Extracted from #39.
This has some small clean-ups before running Konvert on the EntryPointOptions type.

Extracted from #29
@Nava2 Nava2 force-pushed the kevin/entrypoints-clean-up branch from 46a9e87 to 8c40cee Compare April 23, 2023 18:12
@Nava2 Nava2 merged commit a3e2d84 into main Apr 23, 2023
@Nava2 Nava2 deleted the kevin/entrypoints-clean-up branch April 23, 2023 18:17
Nava2 added a commit that referenced this pull request Apr 23, 2023
This does a direct conversion from Groovy -> `Kotlin`. There are zero functional changes.

Depends on #39, extracted from #29.
Nava2 added a commit that referenced this pull request Apr 23, 2023
Nava2 added a commit that referenced this pull request Apr 23, 2023
Nava2 added a commit that referenced this pull request Apr 23, 2023
Nava2 added a commit that referenced this pull request Apr 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant