[Simplify] Flatten DefaultAssertJGeneratorOptions into single class
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le extensions This replaces the "Conventions" and "custom source sets" in favour of using a simple task + `extension` on any `SourceSet` that are defined. This *greatly* simplifies the code and matches all tests still. Further, this properly adds support for incremental changes in templates as they were not correctly implemented before. This was extracted from #17.
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
… extension directly attached to `sourceSet`
This removes the custom `AssertJSourceSet` which was not adding value with the new functionality in modern gradle that generates methods to configure extensions for those that they are attached to. For example, the `assertJ {}` closure is handled by the `extension` rather than adding a new `SourceSet` type.
This was extracted from #31
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
… extension directly attached to `sourceSet`
This removes the custom `AssertJSourceSet` which was not adding value with the new functionality in modern gradle that generates methods to configure extensions for those that they are attached to. For example, the `assertJ {}` closure is handled by the `extension` rather than adding a new `SourceSet` type.
This was extracted from #31
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
… extension directly attached to `sourceSet`
This removes the custom `AssertJSourceSet` which was not adding value with the new functionality in modern gradle that generates methods to configure extensions for those that they are attached to. For example, the `assertJ {}` closure is handled by the `extension` rather than adding a new `SourceSet` type.
This was extracted from #31
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
This was objectively wrong and shouldnt have been done. The correct approach is to register this plugin when the `java` plugin is registered. Extracted from #31
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
This was objectively wrong and shouldnt have been done. The correct approach is to register this plugin when the `java` plugin is registered. Extracted from #31
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
… extension directly attached to `sourceSet`
This removes the custom `AssertJSourceSet` which was not adding value with the new functionality in modern gradle that generates methods to configure extensions for those that they are attached to. For example, the `assertJ {}` closure is handled by the `extension` rather than adding a new `SourceSet` type.
This was extracted from #31
Nava2
force-pushed
the
kevin/remove-convention-garbage
branch
from
7f88eb5 to
a4ecbaf
Compare
Nava2
commented
Apr 22, 2023
src/main/groovy/org/assertj/generator/gradle/AssertJGeneratorGradlePlugin.groovy
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| project.afterEvaluate { |
There was a problem hiding this comment.
None of this was needed...
Nava2
added a commit
that referenced
this pull request
Apr 22, 2023
#33) … extension directly attached to `sourceSet` This removes the custom `AssertJSourceSet` which was not adding value with the new functionality in modern gradle that generates methods to configure extensions for those that they are attached to. For example, the `assertJ {}` closure is handled by the `extension` rather than adding a new `SourceSet` type. This was extracted from #31
Nava2
changed the title
DefaultAssertJGeneratorOptions into single class
Nava2
changed the title
DefaultAssertJGeneratorOptions into single classDefaultAssertJGeneratorOptions into single class
10 tasks
scordio
approved these changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flattens the
DefaultAssertJGeneratorOptionsinto a single classAssertJGeneratorOptionsas the "Default" version was always used. This greatly simplifies the code and removes the strangely existingjavainterfacethat remained.Extracted from #29 without
Konvertyet.