165 link proptypes #170
Merged
165 link proptypes #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if the desire is to only show an icon
alishaevn
commented
Feb 24, 2023
Comment on lines
+7
to
+13
| return ( | ||
| <a | ||
| href={href} | ||
| className={`link ${addClass}`} | ||
| style={style} | ||
| {...props} | ||
| > |
There was a problem hiding this comment.
the majority of this is indention.
alishaevn
commented
Feb 24, 2023
| {icon && ( | ||
| <FontAwesomeIcon icon={icon} className={`small ${label.length && 'me-2'}`} /> | ||
| )} | ||
| {label && label} |
There was a problem hiding this comment.
only show the label if it isn't an empty string.
alishaevn
commented
Feb 24, 2023
Comment on lines
+23
to
+26
| * there isn't an easy way to require either the icon OR the label. there are additional packages we could install that have the | ||
| * capability, but that would bloat the package unnecessarily. instead, we're requiring that the label be passed. the overwhelming | ||
| * majority of instances where a link is used, will want a label anyway. however, in the event a label isn't desired, passing the | ||
| * value as an empty string will satisfy prop types, while still only showing an icon. |
There was a problem hiding this comment.
I tried this suggestion, but it felt like overkill.
Closed
2 tasks
summer-cook
approved these changes
Feb 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
story
expected behavior
demo
link with just text
link with text and an icon
link with just an icon