#1513: Print source of assemblies dependencies in dnu list --assembly #1611

troydai · 2015-04-07T18:26:37Z

Sample:

Command: 

dnu list --assebmly

C:\Users\trdai\.dnx\packages\System.AppContext\4.0.0-beta-22806\lib\aspnetcore50\System.AppContext.dll
    from package: System.AppContext
C:\Users\trdai\.dnx\packages\System.Collections.Concurrent\4.0.10-beta-22806\lib\aspnetcore50\System.Collections.Concurrent.dll
    from package: System.Collections.Concurrent
C:\Users\trdai\.dnx\packages\System.Collections\4.0.10-beta-22806\lib\aspnetcore50\System.Collections.dll
    from package: System.Collections
    from assembly: System.Linq, System.Collections.Concurrent, System.IO.FileSystem
C:\Users\trdai\.dnx\packages\System.ComponentModel\4.0.0-beta-22806\lib\aspnetcore50\System.ComponentModel.dll
    from package: System.ComponentModel
C:\Users\trdai\.dnx\packages\System.Console\4.0.0-beta-22806\lib\aspnetcore50\System.Console.dll
    from package: System.Console
C:\Users\trdai\.dnx\packages\System.Diagnostics.Debug\4.0.10-beta-22806\lib\aspnetcore50\System.Diagnostics.Debug.dll
    from package: System.Diagnostics.Debug
    from assembly: System.Linq, System.Collections.Concurrent
C:\Users\trdai\.dnx\packages\System.IO.FileSystem.Primitives\4.0.0-beta-22806\lib\aspnetcore50\System.IO.FileSystem.Primitives.dll
    from package: System.IO.FileSystem.Primitives
    from assembly: System.Console, System.IO.FileSystem
C:\Users\trdai\.dnx\packages\System.IO.FileSystem\4.0.0-beta-22806\lib\aspnetcore50\System.IO.FileSystem.dll
    from package: System.IO.FileSystem
C:\Users\trdai\.dnx\packages\System.IO\4.0.10-beta-22806\lib\aspnetcore50\System.IO.dll
    from package: System.IO
    from assembly: System.Console, System.IO.FileSystem
C:\Users\trdai\.dnx\packages\System.Linq\4.0.0-beta-22806\lib\aspnetcore50\System.Linq.dll

To get a clean list, using

dnu list --assembly --hide-dependents

troydai · 2015-04-07T18:26:57Z

/cc @davidfowl @Praburaj @victorhurdugaci @muratg

victorhurdugaci · 2015-04-07T20:10:44Z

src/Microsoft.Framework.PackageManager/List/AssemblyWalker.cs

        {
            // determine if keep walking down the path
-            if (ancestors.Any(a => a == assembly))
+            if (ancestors.Any(a => a == assemblyName))


string.Equals

troydai · 2015-04-08T17:36:07Z

Ping ⌚

BrennanConroy · 2015-04-08T20:44:31Z

src/Microsoft.Framework.PackageManager/List/AssemblyWalker.cs

-            root.DepthFirstPreOrderWalk(visitNode: (node, _) => VisitLibrary(node, _, libraries, assemblies));
+            root.DepthFirstPreOrderWalk(visitNode: (node, _) => VisitLibrary(node, _, libraries));
+
+


too much /r/n!

Will clean up.

davidfowl · 2015-04-09T08:56:27Z

I think you should invert it. Have a --detailed or a --verbose flag that shows more information.

troydai · 2015-04-09T15:18:05Z

We need to ensure the same experience between listing packages and assembly. So both by default just list the dependencies and use --detailed to show more information. How about that?

troydai · 2015-04-10T07:24:16Z

rebased and updated.

/cc @davidfowl ⌚

troydai · 2015-04-14T07:58:57Z

/cc @davidfowl @BrennanConroy @ChengTian

Adding functional actually testing dnu list.

Each combination of dnx will be uncompressed only once throughout the same test class. It is implemented using a class fixture.
The test will create package dynamically to mimic a dependencies, so that the dnu restore won't rely on an external source. The dependencies will be manageable. @BrennanConroy this can be reused in dnu restore functional tests.

pranavkm · 2015-04-14T12:35:48Z

src/Microsoft.Framework.PackageManager/List/AssemblyWalker.cs

        {
-            var assemblies = new HashSet<string>();
+            _assemblyFilePaths = new HashSet<string>();


StringComparer.Ordinal (also for the dictionaries).

troydai · 2015-04-14T16:23:09Z

Looks like test fails on mono. I'm looking at it.

troydai · 2015-04-14T17:00:33Z

⌚ /cc @davidfowl

troydai · 2015-04-14T17:01:11Z

Also address: #1644

BrennanConroy · 2015-04-14T17:20:44Z

test/Microsoft.Framework.PackageManager.FunctionalTests/DnuListTests.cs

+            string stdOut, stdErr;
+            Assert.Equal(0, DnuTestUtils.ExecDnu(runtimeHomePath, "list", "--details", out stdOut, out stdErr, environment: null, workingDir: _workingDir.DirPath));
+
+            string[] outputLines = stdOut.Split(Environment.NewLine[0]);


Why are you grabbing potentially only part of the newline?

Environment.NewLine[0] in both situation is \n. In the following assertions string.Contains is used to examine the content. It is safe.

BrennanConroy · 2015-04-14T17:33:33Z

⌚ comments

troydai · 2015-04-14T21:00:45Z

test/Microsoft.Framework.PackageManager.FunctionalTests/DnuListTests.cs

+            string stdOut, stdErr;
+            Assert.Equal(0, DnuTestUtils.ExecDnu(runtimeHomePath, "list", "", out stdOut, out stdErr, environment: null, workingDir: _workingDir.DirPath));
+
+            var hits = stdOut.Split('\n').Where(line => line.Contains("* alpha 0.1.0"))


using newline.

troydai · 2015-04-15T07:35:08Z

CI build fails because of myget failing.

davidfowl · 2015-04-15T07:38:25Z

No they aren't:

Microsoft.Framework.PackageManager.DnuPublishTests.PublishExcludeWithLongPath [SKIP]
      Creating long path file failed on Windows Server 2012 R2
   Microsoft.Framework.PackageManager.FunctionalTests.DnuListTests.DnuList_Unresolved(flavor: "mono", os: null, architecture: null) [FAIL]
      System.AggregateException : One or more errors occurred
      ---- System.FormatException : Input string was not in a correct format.
      ---- The following constructor parameters did not have matching fixture data: DnuListTestContext context
      Stack Trace:

         ----- Inner Stack Trace #1 (System.FormatException) -----
           at System.String.ParseFormatSpecifier (System.String str, System.Int32& ptr, System.Int32& n, System.Int32& width, System.Boolean& left_align, System.String& format) [0x00000] in <filename unknown>:0 
           at System.String.FormatHelper (System.Text

troydai · 2015-04-15T07:40:08Z

You caught me. Failure indeed happens on AppVeyor after I put out the statement.

troydai · 2015-04-15T08:05:46Z

continuous-integration/travis-ci/pr fails for

The command "sudo apt-get install -qq mono-complete mono-vbnc fsharp nuget referenceassemblies-pcl" failed and exited with 100 during .

troydai · 2015-04-15T08:20:41Z

/cc @davidfowl @BrennanConroy ⌚

BrennanConroy · 2015-04-15T15:50:21Z

Looks good to go.

troydai · 2015-04-15T17:09:54Z

Ping @davidfowl

troydai · 2015-04-16T16:54:32Z

I'll merge this change today.

davidfowl · 2015-04-16T16:54:54Z

1. Move DnuListTestContext to its own file; 2. Remove unecessary methods; 3. Use Environment.NewLine to split output.

ghost added the cla-not-required label Apr 7, 2015

victorhurdugaci reviewed Apr 7, 2015
View reviewed changes

BrennanConroy reviewed Apr 8, 2015
View reviewed changes

troydai force-pushed the trdai/issue1513 branch from 3d054fa to adf6424 Compare April 9, 2015 22:55

troydai changed the title ~~Print source of assemblies dependencies in dnu list --assembly~~ #1513: Print source of assemblies dependencies in dnu list --assembly Apr 9, 2015

troydai force-pushed the trdai/issue1513 branch 4 times, most recently from d04ee4e to c8fac7b Compare April 10, 2015 07:09

troydai force-pushed the trdai/issue1513 branch 2 times, most recently from 7739575 to e803d3d Compare April 13, 2015 21:52

pranavkm reviewed Apr 14, 2015
View reviewed changes

BrennanConroy reviewed Apr 14, 2015
View reviewed changes

troydai reviewed Apr 14, 2015
View reviewed changes

troydai force-pushed the trdai/issue1513 branch from c9e1ddd to 662c4d9 Compare April 15, 2015 07:19

troydai force-pushed the trdai/issue1513 branch from 662c4d9 to f9479ce Compare April 15, 2015 07:48

troydai force-pushed the trdai/issue1513 branch from f9479ce to 4275745 Compare April 15, 2015 18:02

troydai added 11 commits April 16, 2015 09:55

Print source of assemblies dependencies

83f0164

Compare assembly name using string.Equals

9cbb225

Unless --details is specified, hide dependency sources

23a7dd9

Add functional test for dnu list

4e09f4f

Remove DnuListTestEnvironment

f288c8c

Revert changes in TestUtils.cs

ab59ed2

Futher clean up the test codes

f7a1e3d

1. Move DnuListTestContext to its own file; 2. Remove unecessary methods; 3. Use Environment.NewLine to split output.

User ordinal string comparer in AssemblyWalker

55a3379

Make test Cross-platform

5c6202a

Update DnuListTests and AssemblyWalker to use new C# feature

87676c1

React to TestUtil change

5b4d445

troydai force-pushed the trdai/issue1513 branch from 4275745 to 5b4d445 Compare April 16, 2015 17:26

troydai merged commit 5b4d445 into dev Apr 16, 2015

troydai deleted the trdai/issue1513 branch April 18, 2015 06:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#1513: Print source of assemblies dependencies in dnu list --assembly #1611

#1513: Print source of assemblies dependencies in dnu list --assembly #1611

troydai commented Apr 7, 2015

troydai commented Apr 7, 2015

victorhurdugaci Apr 7, 2015

troydai commented Apr 8, 2015

BrennanConroy Apr 8, 2015

troydai Apr 8, 2015

davidfowl commented Apr 9, 2015

troydai commented Apr 9, 2015

troydai commented Apr 10, 2015

troydai commented Apr 14, 2015

pranavkm Apr 14, 2015

troydai commented Apr 14, 2015

troydai commented Apr 14, 2015

troydai commented Apr 14, 2015

BrennanConroy Apr 14, 2015

troydai Apr 15, 2015

BrennanConroy commented Apr 14, 2015

troydai Apr 14, 2015

troydai commented Apr 15, 2015

davidfowl commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 15, 2015

BrennanConroy commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 16, 2015

davidfowl commented Apr 16, 2015

		root.DepthFirstPreOrderWalk(visitNode: (node, _) => VisitLibrary(node, _, libraries, assemblies));
		root.DepthFirstPreOrderWalk(visitNode: (node, _) => VisitLibrary(node, _, libraries));

#1513: Print source of assemblies dependencies in dnu list --assembly #1611

#1513: Print source of assemblies dependencies in dnu list --assembly #1611

Conversation

troydai commented Apr 7, 2015

troydai commented Apr 7, 2015

victorhurdugaci Apr 7, 2015

Choose a reason for hiding this comment

troydai commented Apr 8, 2015

BrennanConroy Apr 8, 2015

Choose a reason for hiding this comment

troydai Apr 8, 2015

Choose a reason for hiding this comment

davidfowl commented Apr 9, 2015

troydai commented Apr 9, 2015

troydai commented Apr 10, 2015

troydai commented Apr 14, 2015

pranavkm Apr 14, 2015

Choose a reason for hiding this comment

troydai commented Apr 14, 2015

troydai commented Apr 14, 2015

troydai commented Apr 14, 2015

BrennanConroy Apr 14, 2015

Choose a reason for hiding this comment

troydai Apr 15, 2015

Choose a reason for hiding this comment

BrennanConroy commented Apr 14, 2015

troydai Apr 14, 2015

Choose a reason for hiding this comment

troydai commented Apr 15, 2015

davidfowl commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 15, 2015

BrennanConroy commented Apr 15, 2015

troydai commented Apr 15, 2015

troydai commented Apr 16, 2015

davidfowl commented Apr 16, 2015