Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Reference assemblies directory for current .NET is hard-coded #1047

Closed
dougbu opened this issue Jan 8, 2015 · 0 comments
Closed

Reference assemblies directory for current .NET is hard-coded #1047

dougbu opened this issue Jan 8, 2015 · 0 comments
Assignees
@davidfowl
Labels
3 - Done bug
Milestone
1.0.0-beta4

Comments

@dougbu
Copy link
Member

dougbu commented Jan 8, 2015

Whenever 4.5.3 stops being the current version of .NET, kpm build will fail to find some reference assemblies. Should remove this hard-coding before that happens.

See https://github.com/aspnet/KRuntime/blob/dev/src/Microsoft.Framework.Runtime/FrameworkReferenceResolver.cs for a few hard-coded 4.5.3 references. Might be others...
@muratg muratg added this to the 1.0.0-rc1 milestone Jan 8, 2015
@davidfowl davidfowl self-assigned this Jan 8, 2015
davidfowl added a commit that referenced this issue Jan 9, 2015
@davidfowl
Check for net46 before net453.
611ae5b 
- Keep both around for now while we transition over.

#1047
@davidfowl davidfowl mentioned this issue Jan 9, 2015
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-beta4
Development

No branches or pull requests
3 participants
@davidfowl @muratg @dougbu