This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Use pooled StringBuilder to reduce allocations when adding response cookies
#594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// For example, the maximum retained capacity of <see cref="System.Text.StringBuilder"/> instances obtained | ||
| /// from an object pool. | ||
| /// </remarks> | ||
| int MaximumRetainedPooledInstanceCapacity { get; set; } |
There was a problem hiding this comment.
Copying @Tratcher's comment from previous PR: 👎 This is an implementation detail, not a generic feature property.
There was a problem hiding this comment.
What do you suggest? This is at least abstracted from StringBuilder and ObjectPool<T>. I'm loath to expose an even-more-specific ObjectPool<StringBuilder> property anywhere.
One thought: We could expose these properties only on the feature implementation once I fix #592. Then the required downcast would at least be to a public class.
dougbu
force-pushed
the
dougbu/cookie.maker.561.II
branch
from
b5b204c
to
1f2d8bb
Compare
|
🆙📅 |
| using Microsoft.AspNetCore.Http; | ||
| using Microsoft.AspNetCore.Http.Features; | ||
| using Microsoft.AspNetCore.Http.Features.Internal; |
There was a problem hiding this comment.
Won't need this addition once I'm done #592.
|
👍 progress |
|
Much better, I'm not 100% comfortable with this yet. Trying to see how it scales when we add things. |
|
|
🆙📅 addressed @Tratcher's comments |
… cookies - #561 - new `SetCookieHeaderValue.AppendToStringBuilder()` method; avoids per-call `StringBuilder` allocation - `ResponseCookies` uses `ObjectPool<StringBuilder>` that `ResponseCookiesFeature` provides - `ResponseCookiesFeature` creates an `ObjectPoolProvider` instance if none in DI - `IResponseCookiesFeature` exposes `int` properties supporting middleware overrides of the pool policy nit: Add some doc comments
- `IHttpContextFactory` instance is a singleton instantiated from CI - make `HttpContextFactory` `ObjectPoolProvider` and `ResponseCookiesFeature`-aware - apply same pattern to sample `PooledHttpContextFactory` - pool is not currently configurable; defaults are fine for response cookies - if we need (policy) configuration, would add an `IOptions<HttpContextFactorySettings>` - `ResponseCookies` works fine if no `ObjectPoolProvider` is available
dougbu
force-pushed
the
dougbu/cookie.maker.561.II
branch
from
668719b
to
52cb1f9
Compare
| @@ -27,7 +27,7 @@ | |||
| "System.Net.WebSockets": "4.0.0-*", | |||
| "System.Runtime.Extensions": "4.1.0-*", | |||
| "System.Security.Claims": "4.0.1-*", | |||
| "System.Security.Cryptography.X509Certificates": "4.1.0-*", | |||
| "System.Security.Cryptography.X509Certificates": "4.0.0-*", | |||
There was a problem hiding this comment.
Not sure this will be necessary next time CI updates the feed. @pranavkm?
There was a problem hiding this comment.
Yup, the 4.1.0 package is available in the new corefx build.
|
🆙📅 (rebased) ping @Tratcher @davidfowl |
This was referenced Mar 23, 2016
|
|
|
🆙📅 (as requested, @davidfowl) |
dougbu
added a commit
to aspnet/HttpSysServer
that referenced
this pull request
Mar 24, 2016
| using Microsoft.AspNetCore.Http.Features; | ||
| using Microsoft.AspNetCore.Http.Features.Internal; | ||
| using Microsoft.Extensions.ObjectPool; | ||
|
|
||
| namespace Microsoft.AspNetCore.Http.Internal |
There was a problem hiding this comment.
Wasn't the plan to move the Features out of Internal namespace?
dougbu
added a commit
to aspnet/HttpSysServer
that referenced
this pull request
Mar 25, 2016
- remove unused field - see pull aspnet/HttpAbstractions#594 and issue aspnet/HttpAbstractions#561
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResponseCookies.Append()allocates lots, big lots #561SetCookieHeaderValue.AppendToStringBuilder()method; avoids per-callStringBuilderallocationResponseCookiesusesObjectPool<StringBuilder>thatResponseCookiesFeatureprovidesResponseCookiesFeaturecreates anObjectPoolProviderinstance if none in DIIResponseCookiesFeatureexposesintproperties supporting middleware overrides of the pool policynit: Add some doc comments