Remove IsLocal

[BrennanConroy]

#536

@Tratcher

Will need to update a couple repos when this goes in

[Tratcher]

Check Hosting, WebListener, Kestrel, and BasicMiddleware.

[davidfowl]

[davidfowl]

Related to this idea, should we move IsHttps to an extension method?

[Tratcher]

@davidfowl shrug. Last chance if you're going to, but it's not a priority.

[davidfowl]

The weird thing about it not being a computed property is that the actual scheme and IsHttps can be out of sync. I'm not aware of that being an intentional design choice.

[Tratcher]

Well, it is actually computed: https://github.com/aspnet/HttpAbstractions/blob/dev/src/Microsoft.AspNet.Http/DefaultHttpRequest.cs#L98-L102, but I guess that's not a guaranteed implementation detail.

[brockallen]

I'd very much like the IsHttps property to be kept. My $0.02.

[davidfowl]

Might make sense to make these things all computed and not settable. It means that middleware can't change it but if there's a better source of truth anyways then that might be ok.

[BrennanConroy]

🆙 📅 Removed IsLocal from IHttpConnectionFeature

[Tratcher]