Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

new ApplicationBuilder(ApplicationBuilder builder) should copy the Properties dictionary #783

Closed
tuespetre opened this issue Mar 6, 2017 · 1 comment
Assignees

Comments

@tuespetre
Copy link
Contributor

tuespetre commented Mar 6, 2017

As I was trying to use Map and set a custom service provider ApplicationServices within the branch, I found that setting ApplicationServices on the branched application was also setting it on the application builder that was branched from, due to both application builders sharing the same properties dictionary. This feels counter-intuitive -- I expected that a new IApplicationBuilder in a new branch would have its own properties.

@muratg
Copy link

muratg commented Mar 20, 2017

@tuespetre Interested in sending a PR? If you do, please use https://github.com/aspnet/Common/blob/dev/shared/Microsoft.Extensions.CopyOnWriteDictionary.Sources/CopyOnWriteDictionary.cs instead of doing a clone on the constructor.

@muratg muratg added this to the Backlog milestone Mar 20, 2017
@muratg muratg added the bug label Mar 20, 2017
tuespetre added a commit to tuespetre/HttpAbstractions that referenced this issue Mar 21, 2017
@davidfowl davidfowl modified the milestones: 2.0.0, Backlog Mar 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants