-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-do the build infrastructure #445
Conversation
Copied from Microsoft-reverse-proxy [skip ci]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of questions and I still have ~100 files to look at. Before I do that, can most of the C# files be blithely ignored❔ And, where did the new projects come from❔
"tools": { | ||
"dotnet": "6.0.100" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What requires a .NET SDK be installed w/o enforcing a version❔
"tools": { | |
"dotnet": "6.0.100" | |
"sdk": { | |
"version": "6.0.100" | |
}, | |
"tools": { | |
"dotnet": "6.0.100" |
Might also be worthwhile adding "allowPrerelease"
and "rollForward"
values to make it easier to build on random people's machines.
Oh, that's odd. Why does this repo have an official pipeline but nothing to validate public PRs❔ |
Much of this list is external to the repo. Publishing is handled by adding a Maestro++ ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I also ignored .cs file changes & deletions - looks mostly good, but you can remove most of the files copied over from Arcade
Co-authored-by: Doug Bunting <6431421+dougbu@users.noreply.github.com>
The CI used to be provided by old services that have been discontinued. Replacing it wasn't a priority given this project is in maintenance mode. It should be easier now that we're back on current infrastructure. |
I think @Tratcher just has to create one on https://dev.azure.com/dnceng/public/_build and link it to the .yml file - docs: https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/MovingFromDevDivToDncEng.md, https://github.com/dotnet/arcade/blob/main/Documentation/AzureDevOps/AzureDevOpsGuidance.md#pipelines. You should also set up the mirror bot to mirror the github repo to the azdo repo if you haven't already |
This is a complete replacement of the build infrastructure:
Follow ups:
Cut:
Note, a lot of this was copied from reverse-proxy and aspnetcore, there are likely things that could be removed. Please let me know if you spot any.