Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix existing package check during release #10

Merged

Conversation

fredimachado
Copy link
Contributor

@fredimachado fredimachado commented Jun 3, 2024

Fixes existing package checks and adds double-brackets for improved bash string comparison.

The _version variable doesn't actually exist in the script.

This will always return 404: https://api.nuget.org/v3/registration5-semver1/aspirant.hosting.0.0.4/0.0.4.json

This is the correct link: https://api.nuget.org/v3/registration5-semver1/aspirant.hosting/0.0.4.json

The double-brackets should fix the error on line 19.

image

This also fixes the Node.js warning:
image

@fredimachado fredimachado changed the title Fix existing package check Fix existing package check during release Jun 3, 2024
Copy link
Member

@DamianEdwards DamianEdwards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@DamianEdwards DamianEdwards merged commit 757f22c into aspirant-project:main Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants