UPNP: Two retries

lib/interfaces/kaspad.js

@@ -16,6 +16,7 @@ module.exports = class Kaspad extends Daemon {
 		this.data = [ ];
 
 		this.upnpClient = new natUpnp.Client({timeout: 4000});
+		this.upnpRetries = 2;
 		this.upnpTtl = 7200; // 2 hours
 		this.upnpRenewalSec = Math.floor(this.upnpTtl / 4);
 		this.upnpRenewalInterval = null;
@@ -58,7 +59,7 @@ module.exports = class Kaspad extends Daemon {
 						this.writeToSink(`KASPAD: Adding externalip=${externalip} to arguments\n`);
 						args['externalip'] = externalip;
 					}
-					const publicPort = await this.forwardPort(nodePort, true);
+					const publicPort = await this.forwardPort(nodePort, this.upnpRetries);
 					if (publicPort) {
 						if (publicPort !== nodePort) {
 							this.writeToSink(`KASPAD: Changing listener port from ${nodePort} to ${publicPort} in arguments\n`);
@@ -160,7 +161,7 @@ module.exports = class Kaspad extends Daemon {
 		});
 	}
 
-	forwardPort(port, retry) {
+	forwardPort(port, retries) {
 		return new Promise(resolve => setTimeout(resolve, 1000)).then(() => {
 			return this.upnpClient.createMapping({
 				public: port,
@@ -172,10 +173,10 @@ module.exports = class Kaspad extends Daemon {
 				this.scheduleRenewal(port);
 				return port;
 			}).catch((err) => {
-				if (retry) {
+				if (retries) {
 					const alternativePort = Math.floor(Math.random() * 45000) + 20000;
 					this.writeToSink(`UPNP: Mapping of public port ${port} failed, trying alternative port ${alternativePort}.\n`.yellow);
-					return this.forwardPort(alternativePort);
+					return this.forwardPort(alternativePort, --retries);
 				} else {
 					this.writeToSink(`UPNP: Mapping of public port ${port} failed: ${err.message}\n`.red);
 				}