Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove predeclared asset outputs #586

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: remove predeclared asset outputs #586

merged 1 commit into from
Apr 25, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 11, 2024 •
edited
Loading

BREAKING CHANGE: assets are no longer pre-declared outputs of the ts_project API

Fix #579

Type of change

  • Bug fix (change which fixes an issue)

Test plan

  • Covered by existing test cases
  • New test cases added

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 11, 2024 •
edited
Loading

Test

1 test target was executed and passed with no errors or flakes 🙌

Targets 
//docs:update_0_test [k8-fastbuild] 77ms

Total test execution time was 77ms. 66 tests (98.5%) were fully cached saving 6s.

Buildifier      Format

@jbedard jbedard marked this pull request as draft April 11, 2024 22:04
@jbedard jbedard force-pushed the rm-predeclared-assets branch from 9a023db to b437895 Compare April 11, 2024 22:05
@jbedard jbedard changed the base branch from main to 2.x April 24, 2024 21:25
@jbedard jbedard changed the base branch from 2.x to 3.x April 24, 2024 21:25
@jbedard jbedard force-pushed the rm-predeclared-assets branch from b437895 to b0a0c77 Compare April 24, 2024 21:26
@jbedard jbedard requested a review from gregmagolan April 24, 2024 21:26
@jbedard jbedard marked this pull request as ready for review April 24, 2024 21:26
gregmagolan
gregmagolan approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@gregmagolan gregmagolan merged commit 9dea140 into aspect-build:3.x Apr 25, 2024
1 check passed
gregmagolan pushed a commit that referenced this pull request Apr 25, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
b980f00
gregmagolan pushed a commit that referenced this pull request Apr 29, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
01b43ba
gregmagolan pushed a commit that referenced this pull request Apr 30, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
9893e70
gregmagolan pushed a commit that referenced this pull request Apr 30, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
194b442
gregmagolan pushed a commit that referenced this pull request Apr 30, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
743b98d
gregmagolan pushed a commit that referenced this pull request Apr 30, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
d6118b6
gregmagolan pushed a commit that referenced this pull request May 9, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
7e1cc9b
gregmagolan pushed a commit that referenced this pull request May 9, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
de07bf5
gregmagolan pushed a commit that referenced this pull request May 11, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
96cbe67
gregmagolan pushed a commit that referenced this pull request May 14, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
a2a5564
gregmagolan pushed a commit that referenced this pull request May 21, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
8a5650f
gregmagolan pushed a commit that referenced this pull request May 21, 2024
@jbedard @gregmagolan
fix: remove predeclared asset outputs (#586)
71118ab
@jbedard jbedard mentioned this pull request Jun 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: generated ts_project(assets) cause conflicting actions error
2 participants
@jbedard @gregmagolan