Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix safe_flag parsing in clang_tidy.bzl #300

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Fix safe_flag parsing in clang_tidy.bzl #300

merged 2 commits into from
Jun 21, 2024

Conversation

jsharpe
Copy link
Contributor

@jsharpe jsharpe commented Jun 20, 2024

Fixes parameter shadowing in the _safe_flags macro.

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes/no
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Pass C++ toolchain and copt flags to clang-tidy.

Test plan

  • Covered by existing test cases

@jsharpe jsharpe mentioned this pull request Jun 20, 2024
Open
peakschris
peakschris approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@peakschris peakschris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for fixing

@alexeagle alexeagle merged commit dee1cf0 into aspect-build:main Jun 21, 2024
1 check passed
@alexeagle alexeagle mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peakschris peakschris peakschris approved these changes

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsharpe @alexeagle @peakschris