Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump example to bazel-lib 2.7.5 #254

Merged
merged 2 commits into from
May 23, 2024
Merged

chore: bump example to bazel-lib 2.7.5 #254

merged 2 commits into from
May 23, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented May 23, 2024 •
edited
Loading

bazel-lib 2.7.3 has a bad URL in coreutils for darwin x86

@gregmagolan gregmagolan requested review from alexeagle and mrmeku May 23, 2024 20:21
mrmeku
mrmeku reviewed May 23, 2024
View reviewed changes
Copy link
Contributor

@mrmeku mrmeku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note sure why, but CI seems to want an older version of aspect_bazel_lib

module not found in registries: aspect_bazel_lib@2.7.4

@alexeagle
Copy link
Member

Something is broken in 2.7.4. Fix is https://github.com/aspect-build/bazel-lib/pull/854/files (bigger fix but was tech debt we've wanted to do anyway)

@gregmagolan gregmagolan force-pushed the bump_example_to_bazel_lib_274 branch from a1fc25f to fb5e9f2 Compare May 23, 2024 23:21
@gregmagolan
Copy link
Member Author

Updated to 2.7.5

@gregmagolan gregmagolan changed the title chore: bump example to bazel-lib 2.7.4 chore: bump example to bazel-lib 2.7.5 May 23, 2024
@gregmagolan gregmagolan force-pushed the bump_example_to_bazel_lib_274 branch from fb5e9f2 to eea40b7 Compare May 23, 2024 23:21
@alexeagle alexeagle merged commit d420ca0 into main May 23, 2024
8 checks passed
@alexeagle alexeagle deleted the bump_example_to_bazel_lib_274 branch May 23, 2024 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrmeku mrmeku mrmeku approved these changes

@alexeagle alexeagle alexeagle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gregmagolan @alexeagle @mrmeku