Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: lint_stylelint_aspect does not include config dependencies #394

Closed
sallustfire opened this issue Sep 20, 2024 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@sallustfire
Copy link
Contributor

What happened?

In analogy with eslint, the typical setup for the stylelint config file is to copy it to the output tree as a js_library. The config file may depend on external stylelint plugins which need to be made available via runfiles. The implementation only declares a dependency on the config file and does not include the config file's dependencies.

Version

Development (host) and target OS/architectures: Pop!_OS 22.04 LTS

Output of bazel --version: 7.1.1

Language(s) and/or frameworks involved: stylelint

How to reproduce

Add extends to the stylelint config or depend on a plugin.

Any other information?

No response

@sallustfire sallustfire added the bug Something isn't working label Sep 20, 2024
sallustfire added a commit to sallustfire/rules_lint that referenced this issue Sep 20, 2024
If the stylelint config is declared via js_library and has a dependency on
other sources or npm packages, these dependencies are now included in the
linting action.
alexeagle pushed a commit that referenced this issue Sep 20, 2024
* fix: include stylelint config deps (#394)

If the stylelint config is declared via js_library and has a dependency on
other sources or npm packages, these dependencies are now included in the
linting action.

* fix bzl_library deps

* update docs

* format config file
@alexeagle
Copy link
Member

fixed by #395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants